Chore - update qnfs database to using subing.Suber

[m00sey]

Currently the .qnfs sub db uses the "legacy" 😬 approach of creating a Baser property and adding methods to Baser

The sub db created here:

keripy/src/keri/db/basing.py

Line 997 in ce3c235

self.qnfs = self.env.open_db(key=b'qnfs.', dupsort=True)

The additional functionality added to Baser here:

keripy/src/keri/db/basing.py

Line 3031 in ce3c235

def putQnfs(self, key, vals):

Newer sub dbs that have been added using the subing.Suber and associated classes:

keripy/src/keri/db/subing.py

Line 197 in ce3c235

class Suber(SuberBase):

The chore is to update usages of the .qnfs associated functionality from Baser and implement it as a subing.Suber:

self.qnfs = subing.Suber(db=self, subkey="qnfs.")

**.db.addQnf becomes **db.qnfs.add

• add new subing.Suber qnfs sub db to basing
• remove old .qnfs initialization
• updated usages of putQnfs
• removed putQnfs
• updated usages of addQnf
• removed addQnf
• updated usages of getQnfs
• removed getQnfs
• updated usages of getQnfLast
• removed getQnfLast
• updated usages of getQnfItemsNext
• removed getQnfItemsNext
• updated usages of getQnfItemsNextIter
• removed getQnfItemsNextIter
• updated usages of cntQnfs
• removed cntQnfs
• updated usages of delQnfs
• removed delQnfs
• updated usages of delQnf
• removed delQnf

[arilieb]

Working on this now

[arilieb]

Question: delQnf is used to delete a single escrow value at a given key. I am attempting to replace this with functionality from subing.Suber in eventing.py. the Suber class does not have built in functionality for this, as its rem method removes the everything stored at the key, rather than a single value. Which, if any, of the following approaches should I take?

• use a different class, perhaps IoSetSuber, as the rem function from that class seems suited to the task
• use get and pin methods from the Suber class to overwrite the set of values at key with the the values minus the deleted value
• write a new method in the Suber class

[pfeairheller]

You have to look at the existing definition of theqnf database. If is an "insertion order set", (usually indicated by dupsort=True in the table creation), you HAVE to use IoSetSuber. That is the only way this will be a proper replacement.

[arilieb]

Created PR with the discussed changes. #849