Stale read of smids - on multisig rotate neither GroupHab.smids nor HabitatRecord.smids are updated to latest signing members

[kentbull]

Version

1.1.18

Environment

MacOS Sonoma 14.6.1, Python 3.12.3, local deployment

Expected behavior

Calling GroupHab.smids should return the latest smids sent in to a multisig rotate command.

Actual behavior

Currently the smids coming back is exactly what was sent in during the inception event, or for a member being rotated in, the smids as of them being rotated into the group.

Steps to reproduce

Perform a rotation on any multisig AID where you either rotate out one of the original group or rotate a new member in.

If you rotate a member out then both the remaining members will still have the old smids values in their HabitatRecord.smids value.

If you rotate a member in then the original members will not have the new member's AID in their HabitatRecord.smids value, which is what GroupHab.smids is populated from during the Habery.loadHabs() call. The new member will have the correct GroupHab.smids value because it was provided the correct value in the rotation event that brought the new member in, yet on the next rotation if there are any members removed or added then that smids value will then be out of date.

[kentbull]

This is fixed in

• main by fix: update smids and rmids for group lead on new event #858
• v1.1.18 by fix: update smids and rmids on rotate #857