Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing integration test coverage for holding revoked credential #187

Open
lenkan opened this issue Jan 6, 2024 · 2 comments
Open

Missing integration test coverage for holding revoked credential #187

lenkan opened this issue Jan 6, 2024 · 2 comments
Assignees
Labels
improvement Improvement to the codebase revocation

Comments

@lenkan
Copy link
Collaborator

lenkan commented Jan 6, 2024

Previously, we had these lines commented out in the credentials test:

// Recipient check revoked credential
// let revoked = false
// while (!revoked) {
// let cred2 = await client2.credentials().get(holderAidName, creds1[0].sad.d)
// if (cred2.status.s == "1") {
// revoked = true
// }
// await new Promise((resolve) => setTimeout(resolve, 250));
// }
// assert.equal(creds2.length, 1)
// assert.equal(creds2[0].sad.s, schemaSAID)
// assert.equal(creds2[0].sad.i, aid1.prefix)
// assert.equal(creds2[0].status.s, "1") // 1 = revoked
// console.log("Revocation received by recipient")
// Present revoked credential
// await client1
// .credentials()
// .present(issuerAidName, creds1[0].sad.d, verifierAidName, true);
// await new Promise((resolve) => setTimeout(resolve, 5000));
// creds3 = await client3.credentials().list(verifierAidName);
// assert.equal(creds3.length, 1);
// assert.equal(creds3[0].sad.s, schemaSAID);
// assert.equal(creds3[0].sad.i, aid1.prefix);
// assert.equal(creds3[0].status.s, '1'); // 1 = revoked
// console.log('Revocation presented and received by verifier');
.

We should introduce coverage for this feature again. However, just adding the same check does not work currently with new IPEX.

@pfeairheller
Copy link
Member

Fixed with PR #225

@lenkan
Copy link
Collaborator Author

lenkan commented Feb 26, 2024

Fixed with PR #225

@pfeairheller It looks like #225 only includes the revocation itself and only involves the issuer? The issue above was about how the holder of a credential is made aware of a revocation.

Perhaps this should be closed anyway as a "working as intended". But I do think it would be good with an example of how a holder would be made aware that their credential revocation.

@lenkan lenkan reopened this Feb 29, 2024
@lenkan lenkan added the improvement Improvement to the codebase label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to the codebase revocation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants