Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpe-2.28] CSS - drop-shadow filter problems #937

Open
Scony opened this issue Sep 12, 2022 · 7 comments
Open

[wpe-2.28] CSS - drop-shadow filter problems #937

Scony opened this issue Sep 12, 2022 · 7 comments
Assignees
Labels
upstream Related to an upstream bug (or should be at some point) wpe-2.38 wpe-2.42

Comments

@Scony
Copy link

Scony commented Sep 12, 2022

In BBC test suite there are 2 test cases using drop-shadow filter in different contexts:
https://certification.bbctvapps.co.uk/act/test/ui/187/css-supports-shadows/
https://certification.bbctvapps.co.uk/act/test/ui/187/css-supports-filter/
In both cases, latest WPEWebKit 2.28 (and even latest WebKit/WebKit@3142453) randomly yield wrong results.

This is expected outcome:

Screenshot from 2022-09-12 13-01-28
Screenshot from 2022-09-12 12-58-23

And that's how it looks like occasionally:
Screenshot from 2022-09-12 13-07-49
Screenshot from 2022-09-12 13-07-36

To me it looks like some compositing issues - once the CSS properties are poked a bit from web inspector, the shadow is being painted correctly.

@magomez
Copy link

magomez commented Sep 28, 2022

For the record, this is being handled upstream in https://bugs.webkit.org/show_bug.cgi?id=245773

@magomez
Copy link

magomez commented Oct 11, 2022

So I was able to create a simple testcase and reported this upstream as the problem is reproducible there as well (also in Safari). Apple folks told me that it was a duplicated of another issue. I tested the WiP patch that they have in that original issue and it fixed my testcase. I was going to backport that fix to 2.28 when I found that, while the patch fixes my testcase, it doesn't fix the tests reported here :(

So I'm now investigating what's the difference between my testcase and the tests here.

@pgorszkowski-igalia
Copy link

Just some notes which I gathered:

  1. It still does not work in upstream
  2. It works a little bit better with WebKit/WebKit@9ee234d but still it is not rendered correctly without refreshing
  3. Simple test case for this issue(limit to displaying only image with filter dropShadow)
<html>
<head>
<style>
img {
  width: 200px;
  filter: drop-shadow(16px 16px 10px black);
}
</style>
</head>
<body>
<img src="https://certification.bbctvapps.co.uk/act/test/ui/187/css-supports-shadows/iplayerImage.png">
</body>
</html>

@filipe-norte-red
Copy link

Hello @magomez
Is there any update on a possible fix for this issue? It is happening with wpe-2.38 as well. I checked related upstream issues and they are still open.
Thanks

@magomez
Copy link

magomez commented Nov 8, 2023

Yes, this is still and issue in 2.38 and 2.42, as the upstream bug is still open. Seems that there's a PR but has some issues. I'll try to gather info from the upstream devs about it.

@modeveci modeveci added upstream Related to an upstream bug (or should be at some point) wpe-2.38 wpe-2.42 labels Nov 28, 2023
@filipe-norte-red
Copy link

@magomez , did you the chance to get some further info on this issue? Thanks

@magomez
Copy link

magomez commented Dec 8, 2023

@magomez , did you the chance to get some further info on this issue? Thanks

No progress on the upstream issue yet :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Related to an upstream bug (or should be at some point) wpe-2.38 wpe-2.42
Development

No branches or pull requests

6 participants