Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismissing a check does not automatically propagate to other components #12588

Open
2 tasks done
matzeeable opened this issue Sep 25, 2024 · 0 comments
Open
2 tasks done
Labels
enhancement Adding or requesting a new feature.

Comments

@matzeeable
Copy link

Describe the issue

We are using Weblate in a "real" Continuous Localization scenario at translate.owlinfra.de, that means every project has components which reflect the branch of our Git repository. This allows us huge flexibility when building new features, so we can e.g. make user tests with updated translations.

As you can see in this project, there are multiple branches. Each component is a branch on our Git repository. There are now two scenarios which are not scalable with Weblate:

For all our components, we have enabled Allow translation propagation. But when we dismiss a check (e.g. Unchanged translation), this check is not propagated to other components, and we need to "Dismiss" for all our components manually.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

We have an English string in component develop: Marketing. In German, we translate the string to "Marketing". Now we correctly receive the check from Weblate “Unchanged translation” for the develop component:

image

We click on "Dismiss". Afterward, we check another branch, e.g. feat-rml-ro and there we need to "Dismiss" again:

image

Expected behavior

Propagate the dismiss-state to other components and if we use the POST /api/translations/(string: project)/(string: component)/(string: language)/autotranslate/REST API to create a new component for a feature branch, reuse the dismiss-state, too (in reference to #10362).

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

 * Weblate: 5.6.2
 * Django: 5.0.6
 * siphashc: 2.4.1
 * translate-toolkit: 3.13.1
 * lxml: 5.2.2
 * pillow: 10.3.0
 * nh3: 0.2.17
 * python-dateutil: 2.9.0.post0
 * social-auth-core: 4.5.4
 * social-auth-app-django: 5.4.1
 * django-crispy-forms: 2.2
 * oauthlib: 3.2.2
 * django_compressor: 4.5
 * djangorestframework: 3.15.2
 * django-filter: 24.2
 * django-appconf: 1.0.6
 * user-agents: 2.2.0
 * filelock: 3.15.4
 * rapidfuzz: 3.9.3
 * openpyxl: 3.1.5
 * celery: 5.4.0
 * django-celery-beat: 2.6.0
 * kombu: 5.3.7
 * translation-finder: 2.16
 * weblate-language-data: 2024.5
 * html2text: 2024.2.26
 * pycairo: 1.26.1
 * PyGObject: 3.48.2
 * diff-match-patch: 20230430
 * requests: 2.32.3
 * django-redis: 5.4.0
 * hiredis: 2.3.2
 * sentry-sdk: 2.7.1
 * Cython: 3.0.10
 * misaka: 2.1.1
 * GitPython: 3.1.43
 * borgbackup: 1.2.8
 * pyparsing: 3.1.2
 * ahocorasick_rs: 0.22.0
 * python-redis-lock: 4.0.0
 * charset-normalizer: 3.3.2
 * Python: 3.12.4
 * Git: 2.39.2
 * psycopg: 3.2.1
 * psycopg-binary: 3.2.1
 * phply: 1.2.6
 * ruamel.yaml: 0.18.6
 * tesserocr: 2.7.0
 * boto3: 1.34.136
 * zeep: 4.2.1
 * aeidon: 1.15
 * iniparse: 0.5
 * mysqlclient: 2.2.4
 * Mercurial: 6.7.4
 * git-svn: 2.39.2
 * git-review: 2.4.0
 * PostgreSQL server: 15.8
 * Database backends: django.db.backends.postgresql
 * PostgreSQL implementation: psycopg3 (binary)
 * Cache backends: default:RedisCache, avatar:FileBasedCache
 * Email setup: django.core.mail.backends.smtp.EmailBackend: email-smtp.eu-central-1.amazonaws.com
 * OS encoding: filesystem=utf-8, default=utf-8
 * Celery: redis://:WjUonTNhHsgHzp8iM66ofyALIz3u@weblate_redis:6379/1, redis://:WjUonTNhHsgHzp8iM66ofyALIz3u@weblate_redis:6379/1, regular
 * Platform: Linux 5.10.28-scaleway (x86_64)

Weblate deploy checks

System check identified some issues:

INFOS:
?: (weblate.I031) New Weblate version is available, please upgrade to 5.7.2.
        HINT: https://docs.weblate.org/en/weblate-5.6.2/admin/upgrade.html

System check identified 1 issue (1 silenced).

Additional context

No response

@nijel nijel added the enhancement Adding or requesting a new feature. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants