Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Replace classnames with clsx #850

Closed
wants to merge 1 commit into from
Closed

Replace classnames with clsx #850

wants to merge 1 commit into from

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Nov 25, 2021 •
edited
Loading

classnames is not used directly in @westpac/progress-rope - we're using classNames from @westpac/core

Closes #795

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6ea7cc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wojtekmaj wojtekmaj changed the base branch from master to develop November 25, 2021 16:12
@netlify
Copy link

netlify bot commented Nov 25, 2021

✔️ Deploy Preview for westpacgel ready!

🔨 Explore the source changes: b3af21aa7ab23dc099ed818bb1b6f1449bc02bb8

🔍 Inspect the deploy log: https://app.netlify.com/sites/westpacgel/deploys/619fb4dd3346ed00070d850e

😎 Browse the preview: https://deploy-preview-850--westpacgel.netlify.app/

@jaortiz
Copy link
Contributor

jaortiz commented Dec 7, 2021

@wojtekmaj classnames is currently being used as part of another system to make the components backwards compatible with legacy systems at Westpac. I'm currently looking into reworking that entire system and will probably remove classnames altogether so I don't see the value in changing to clsx now. I will remove the double classnames dependency in another pr I am currently working on.

@wojtekmaj wojtekmaj changed the title Remove classnames dependency from @westpac/progress-rope, replace classnames with clsx Replace classnames with clsx Dec 28, 2021
@wojtekmaj wojtekmaj closed this Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider clsx instead of classnames
2 participants
@wojtekmaj @jaortiz