Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit WKT coordinate precision to something reasonable #18

Open
kannes opened this issue Jun 8, 2023 · 1 comment
Open

Limit WKT coordinate precision to something reasonable #18

kannes opened this issue Jun 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kannes
Copy link
Contributor

kannes commented Jun 8, 2023

Limit coordinate precision in the filter string WKT to something reasonable. Don't always use 17 decimal places as that leads to huge filter strings and low performance when activating filters.

6 should be a good default. This is the same that GeoJSON recommends for WGS84 coordinates and usually users will use CRS with finer precision (so each decimal step corresponds with a much smaller spatial step compared to WGS84). Maybe use 7 to be safe.

Maybe add a menu/config option to set it?
@kannes kannes added the enhancement New feature or request label Jun 8, 2023
@kannes kannes changed the title Limit coordinate precision to something reasonable Limit WKT coordinate precision to something reasonable Jun 8, 2023
@kannes
Copy link
Contributor Author

kannes commented Sep 21, 2023

.asWkt(precision=7) for every .asWkt()?

pgipper pushed a commit that referenced this issue Aug 24, 2024
Merge branch '18_notintersects_for_disjoint' into 'main'
e57d07f 
Use NOT ST_Intersects instead of ST_Disjoint for performance

Closes #18

See merge request qgis/hvbg-filterplugin!4
@pgipper pgipper reopened this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kannes @pgipper