Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: WhosNickDoglio/dagger-rules
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 56eed20a322ca051dd16f91792a0796d4eba831a
Choose a base ref
..
head repository: WhosNickDoglio/dagger-rules
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 23fe85f4446dfb52a298eca8653726c7ae5f90be
Choose a head ref
Showing with 240 additions and 1,037 deletions.
  1. +4 −4 .github/actions/setup/action.yml
  2. +4 −4 .github/workflows/ci.yml
  3. +2 −2 .github/workflows/docs.yml
  4. +1 −1 .github/workflows/git-town.yml
  5. +1 −1 .github/workflows/update-gradle-wrapper.yml
  6. +0 −98 build-logic/build.gradle.kts
  7. +0 −11 build-logic/gradle.properties
  8. +0 −2 build-logic/gradle/gradle-daemon-jvm.properties
  9. BIN build-logic/gradle/wrapper/gradle-wrapper.jar
  10. +0 −8 build-logic/gradle/wrapper/gradle-wrapper.properties
  11. +0 −252 build-logic/gradlew
  12. +0 −94 build-logic/gradlew.bat
  13. +0 −9 build-logic/lint-baseline.xml
  14. +0 −39 build-logic/settings.gradle.kts
  15. +0 −22 build-logic/src/main/kotlin/dev/whosnickdoglio/buildlogic/LintPlugin.kt
  16. +0 −47 build-logic/src/main/kotlin/dev/whosnickdoglio/buildlogic/RulesPlugin.kt
  17. +0 −22 build-logic/src/main/kotlin/dev/whosnickdoglio/buildlogic/configuration/GradleExtensions.kt
  18. +0 −50 build-logic/src/main/kotlin/dev/whosnickdoglio/buildlogic/configuration/JvmConfigurations.kt
  19. +0 −24 build-logic/src/main/kotlin/dev/whosnickdoglio/buildlogic/configuration/LintConfiguration.kt
  20. +0 −44 build-logic/src/main/kotlin/dev/whosnickdoglio/buildlogic/configuration/SpotlessConfiguration.kt
  21. +0 −32 build-logic/src/main/kotlin/dev/whosnickdoglio/buildlogic/configuration/TestConfiguration.kt
  22. +15 −22 gradle/libs.versions.toml
  23. +2 −2 gradle/wrapper/gradle-wrapper.properties
  24. +1 −2 gradlew
  25. +11 −1 lint/annotation-constants/build.gradle.kts
  26. +0 −4 lint/annotation-constants/src/testFixtures/java/dev/whosnickdoglio/stubs/Dagger.kt
  27. +0 −2 lint/annotation-constants/src/testFixtures/java/dev/whosnickdoglio/stubs/Hilt.kt
  28. +16 −1 lint/anvil/build.gradle.kts
  29. +0 −3 ...l/src/test/java/dev/whosnickdoglio/anvil/detectors/ContributesBindingMustHaveSuperDetectorTest.kt
  30. +0 −4 .../src/test/java/dev/whosnickdoglio/anvil/detectors/FavorContributesBindingOverBindsDetectorTest.kt
  31. +0 −4 lint/anvil/src/test/java/dev/whosnickdoglio/anvil/detectors/MissingContributesBindingDetectorTest.kt
  32. +0 −6 lint/anvil/src/test/java/dev/whosnickdoglio/anvil/detectors/MissingContributesToDetectorTest.kt
  33. +3 −3 lint/anvil/src/test/java/dev/whosnickdoglio/anvil/detectors/NoAnvilInJavaDetectorTest.kt
  34. +16 −1 lint/dagger/build.gradle.kts
  35. +18 −22 lint/dagger/src/test/java/dev/whosnickdoglio/dagger/detectors/ComponentMustBeAbstractDetectorTest.kt
  36. +0 −2 ...st/java/dev/whosnickdoglio/dagger/detectors/ConstructorInjectionOverFieldInjectionDetectorTest.kt
  37. +0 −8 lint/dagger/src/test/java/dev/whosnickdoglio/dagger/detectors/CorrectBindsUsageDetectorTest.kt
  38. +0 −10 lint/dagger/src/test/java/dev/whosnickdoglio/dagger/detectors/MissingModuleAnnotationDetectorTest.kt
  39. +48 −53 lint/dagger/src/test/java/dev/whosnickdoglio/dagger/detectors/MultipleScopesDetectorTest.kt
  40. +0 −12 ...er/src/test/java/dev/whosnickdoglio/dagger/detectors/ScopedWithoutInjectAnnotationDetectorTest.kt
  41. +0 −2 lint/dagger/src/test/java/dev/whosnickdoglio/dagger/detectors/StaticProvidesDetectorTest.kt
  42. +40 −12 lint/dagger/src/test/java/dev/whosnickdoglio/dagger/detectors/ValidComponentMethodDetectorTest.kt
  43. +16 −1 lint/hilt/build.gradle.kts
  44. +30 −52 lint/hilt/src/test/java/dev/whosnickdoglio/hilt/detectors/EntryPointMustBeAnInterfaceDetectorTest.kt
  45. +0 −2 lint/hilt/src/test/java/dev/whosnickdoglio/hilt/detectors/MissingAndroidEntryPointDetectorTest.kt
  46. +0 −4 ...lt/src/test/java/dev/whosnickdoglio/hilt/detectors/MissingHiltAndroidAppAnnotationDetectorTest.kt
  47. +0 −4 ...ilt/src/test/java/dev/whosnickdoglio/hilt/detectors/MissingHiltViewModelAnnotationDetectorTest.kt
  48. +9 −28 lint/hilt/src/test/java/dev/whosnickdoglio/hilt/detectors/MissingInstallInDetectorTest.kt
  49. +3 −4 settings.gradle.kts
8 changes: 4 additions & 4 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
@@ -8,21 +8,21 @@ runs:
using: "composite"
steps:
- name: set up JDK 23
uses: actions/setup-java@8df1039502a15bceb9433410b1a100fbe190c53b # v4.5.0
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0
with:
distribution: 'zulu'
java-version: '23'
- name: Set up jemalloc
uses: kaeawc/setup-jemalloc@97ffdab77f76db0584b4d9cfb036fab6457d5526 # v0.0.3
- name: Setup Gradle
uses: gradle/actions/setup-gradle@473878a77f1b98e2b5ac4af93489d1656a80a5ed # v4
uses: gradle/actions/setup-gradle@94baf225fe0a508e581a564467443d0e2379123b # v4
with:
cache-encryption-key: ${{ inputs.encryption_key }}

# Stolen from here https://github.com/kaeawc/android-build/blob/a86b15e3cbc5d36339a97d09f46c7a22e276ff7f/.github/actions/gradle-task-run/action.yml#L140
- name: "Restore Android SDK Platform Tools"
id: cache-android-platform-tools
uses: actions/cache/restore@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4
uses: actions/cache/restore@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
with:
path: |
/usr/local/lib/android/sdk/platform-tools
@@ -32,7 +32,7 @@ runs:
if: steps.cache-android-platform-tools.outputs.cache-hit != 'true'
uses: android-actions/setup-android@9fc6c4e9069bf8d3d10b2204b1fb8f6ef7065407 # v3.2.2
- name: "Save Android SDK Platform Tools"
uses: actions/cache/save@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4
uses: actions/cache/save@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
if: steps.cache-android-platform-tools.outputs.cache-hit != 'true'
with:
path: |
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ jobs:
with:
encryption_key: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
- name: Gradle Wrapper Validation
uses: gradle/actions/wrapper-validation@473878a77f1b98e2b5ac4af93489d1656a80a5ed # v4
uses: gradle/actions/wrapper-validation@94baf225fe0a508e581a564467443d0e2379123b # v4
Build:
runs-on: ubuntu-latest
needs: [ Validate-Gradle ]
@@ -38,7 +38,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Danger
uses: danger/kotlin@783edcc5daee0a66ce14aecdf656f86a7b093135 # 1.3.1
uses: danger/kotlin@9f3eb34dc1a5d5d69bddc64441b2eabd96462864 # 1.3.2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Lint:
@@ -65,12 +65,12 @@ jobs:
- name: Run Unit Tests
run: ./gradlew kover-aggregate:koverXmlReport --no-build-cache
- name: Codecov
uses: codecov/codecov-action@5c47607acb93fed5485fdbf7232e8a31425f672a # v5.0.2
uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1
with:
files: ./kover-aggregate/build/reports/kover/report.xml
token: ${{ secrets.CODE_COV_TOKEN }}
- name: Publish Test Report
uses: mikepenz/action-junit-report@a427a90771729d8f85b6ab0cdaa1a5929cab985d # v5
uses: mikepenz/action-junit-report@ee6b445351cd81e2f73a16a0e52d598aeac2197f # v5
if: success() || failure() # always run even if the previous step fails
with:
report_paths: '**/build/reports/kover/report.xml'
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
@@ -11,10 +11,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5
- uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5
with:
python-version: 3.x
- uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4
- uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
with:
key: ${{ github.ref }}
path: .cache
2 changes: 1 addition & 1 deletion .github/workflows/git-town.yml
Original file line number Diff line number Diff line change
@@ -16,4 +16,4 @@ jobs:

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: git-town/action@7cec053e109396e49a15328a749b32552e6f91db # v1
- uses: git-town/action@8a6469b6e49b1d8c8eac1daf542ce05fac587308 # v1
2 changes: 1 addition & 1 deletion .github/workflows/update-gradle-wrapper.yml
Original file line number Diff line number Diff line change
@@ -12,4 +12,4 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: ./.github/actions/setup
- name: Update Gradle Wrapper
uses: gradle-update/update-gradle-wrapper-action@9268373d69bd0974b6318eb3b512b8e025060bbe # v2
uses: gradle-update/update-gradle-wrapper-action@9cca748ef7cfd967bc3a5c39e15a7aa229ad1b3d # v2
98 changes: 0 additions & 98 deletions build-logic/build.gradle.kts

This file was deleted.

11 changes: 0 additions & 11 deletions build-logic/gradle.properties

This file was deleted.

2 changes: 0 additions & 2 deletions build-logic/gradle/gradle-daemon-jvm.properties

This file was deleted.

Binary file removed build-logic/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
8 changes: 0 additions & 8 deletions build-logic/gradle/wrapper/gradle-wrapper.properties

This file was deleted.

Loading