-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links from course description and timeline should open in new tabs #1393
Comments
I would like to work on this one |
@majakomel is this https://css-tricks.com/snippets/jquery/open-external-links-in-new-window/ - ok trick? |
I have opened PR #1397 but it solves the issue only for links in course description (needed only markdown parser config). Timeline content is unlike course description stored as HTML and Trix editor doesn't have this option. I could either parse the content and add |
@testa19 one other option that might fix it 90% of the way would be to add target="_blank" to all the pregenerated timeline html from the wizard content.yml files. I'm not sure whether Trix will strip that out upon saving an edit, though. The description is the more important part. I definitely don't want to resort to jquery to define that behavior. If we're going to do it for the Trix html, I think we should keep it within the React domain. It looks like there are some possible approaches discussed here: |
…ks-new-tab-#1393 Open course description links in new tab Partially addresses #1393
The course description fix is merged. |
Most of these are links to external resources, so it will be better if they open a new tab instead of navigating away.
I'm not sure whether this can be done with CSS, or whether it will require tweaks to the markdown parser config, or what.
The text was updated successfully, but these errors were encountered: