From f0ed9fcaab1f896993e211d10fbb2219bcdc389d Mon Sep 17 00:00:00 2001 From: Formasitchijoh Date: Tue, 17 Dec 2024 05:47:30 +0100 Subject: [PATCH 1/2] fix: add missing interface message does_not_exist, used in the feedback modal when a course has no rating --- config/locales/en.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/config/locales/en.yml b/config/locales/en.yml index 8e82b21e90..29958d22a3 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -481,6 +481,7 @@ en: active_courses: Active Courses add_trainings: Please add student trainings to your assignment timeline. Assigning training modules is an essential part of Wiki Ed's best practices. alerts: Alerts + does_not_exist: The Item doesn't exist. Create a Sandbox page and assign yourself to that to receive suggestions. all_courses: All Courses already_enrolled: You are already a part of '%{title}'! already_exists: That already exists for this course! From 677d73179e26b0d5fc27d265e12fe331b1459353 Mon Sep 17 00:00:00 2001 From: Formasitchijoh Date: Tue, 17 Dec 2024 05:59:55 +0100 Subject: [PATCH 2/2] fix: failing test in assigned_article_spec by waiting for the component to be available before interacting with it --- spec/features/assigned_articles_spec.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/features/assigned_articles_spec.rb b/spec/features/assigned_articles_spec.rb index 72d966f9d1..0537888615 100644 --- a/spec/features/assigned_articles_spec.rb +++ b/spec/features/assigned_articles_spec.rb @@ -23,6 +23,8 @@ visit "/courses/#{course.slug}/articles/assigned" expect(page).to have_content('Nancy Tuana') find('a', text: 'Feedback').click + expect(page).to have_no_content(I18n.t('courses.feedback_loading')) + expect(page).to have_selector('textarea.feedback-form') find('textarea.feedback-form').fill_in with: 'This is a great article!' click_button 'Add Suggestion' find('a', text: 'Delete').click