[Fabric] Fix initial sync on join, defer syncing to entity load, add client-sided hurt sounds #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celestialfault
force-pushed
the
refactor/networking
branch
from
902aa99 to
754efa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #116, along with fixing the initial sync not occurring on dedicated servers due to the server join event being registered along with client events, and deferring syncing settings to other players until they're within render distance.
This additionally resolves #83 by adding client-sided hurt sounds; this also replaces the
hurtpacket with sending the hurt sound itself from the server.There's been some testing of this PR, but not extensively; the sync changes have only seen extremely minimal testing (read: the mod doesn't break in singleplayer and servers without the mod), while the hurt sound changes have been fairly reasonably well tested.