Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify small/large floe area thresholds #564

Open
cpaniaguam opened this issue Feb 12, 2025 · 0 comments · May be fixed by #566
Open

Unify small/large floe area thresholds #564

cpaniaguam opened this issue Feb 12, 2025 · 0 comments · May be fixed by #566
Assignees
Labels
enhancement New feature or request

Comments

@cpaniaguam
Copy link
Member

cpaniaguam commented Feb 12, 2025

It'd be good to clarify the logic here. On the one hand, I'd love to replace the thresholds with functions that depend on area, on the other hand that's a bigger change than we can really do right now and the thing we need to do is find the settings that make the original approach as logical as we can. I agree that having the cutoffs differ is a problem and a single cutoff would make sense -- it looks like later in the code 1200 is used for both.

Perhaps we want "small_floe_minimum_area", so that only floes larger than that are tracked, and a "large_floe_minimum_area", so that a floe with area A can be cleanly divided as:

  • A < small_floe_minimum_area --> don't track
  • small_floe_minimum_area <= A < large_floe_minimum_area --> use the small_floe_settings
  • large_floe_minimum_area <= A --> use the large_floe_settings.

Originally posted by @danielmwatkins in #551 (comment)

@cpaniaguam cpaniaguam self-assigned this Feb 12, 2025
@cpaniaguam cpaniaguam added the enhancement New feature or request label Feb 12, 2025
@cpaniaguam cpaniaguam moved this from To do to In progress in Ice Floe Coding Tasks Feb 12, 2025
@cpaniaguam cpaniaguam moved this from In progress to Next Up in Ice Floe Coding Tasks Feb 12, 2025
@cpaniaguam cpaniaguam added this to the IFT Data Process milestone Feb 12, 2025
@cpaniaguam cpaniaguam linked a pull request Feb 13, 2025 that will close this issue
@cpaniaguam cpaniaguam linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Next Up
Development

Successfully merging a pull request may close this issue.

1 participant