From dd05ef6ffa48752efa33f68298c85a767df02679 Mon Sep 17 00:00:00 2001 From: Sunil Narasimhamurthy Date: Tue, 7 Nov 2023 05:30:14 +0000 Subject: [PATCH] deps: update the deprecation status of libcurl (#30731) Following the merge of #29880 and #30626 we can mark the curl usage as deprecated. Meanwhile bazel/repositories.bzl had stale info that OpenCensus tracer was still using libcurl. We can continue to keep the Issue #11816 open until curl is removed entirely after the deprecation time (Probably for v1.31 release). Signed-off-by: Sunil Narasimhamurthy --- bazel/repositories.bzl | 4 +++- bazel/repository_locations.bzl | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/bazel/repositories.bzl b/bazel/repositories.bzl index 9f7ab5854d4e..a28ce2e347ad 100644 --- a/bazel/repositories.bzl +++ b/bazel/repositories.bzl @@ -1002,7 +1002,9 @@ def _io_opencensus_cpp(): ) def _com_github_curl(): - # Used by OpenCensus Zipkin exporter. + # The usage by AWS extensions common utilities is deprecated and will be removed by Q3 2024 after + # the deprecation period of 2 releases. Please DO NOT USE curl dependency for any new or existing extensions. + # See https://github.com/envoyproxy/envoy/issues/11816 & https://github.com/envoyproxy/envoy/pull/30731. external_http_archive( name = "com_github_curl", build_file_content = BUILD_ALL_CONTENT + """ diff --git a/bazel/repository_locations.bzl b/bazel/repository_locations.bzl index 640c83a9c696..93635b523a57 100644 --- a/bazel/repository_locations.bzl +++ b/bazel/repository_locations.bzl @@ -1068,7 +1068,8 @@ REPOSITORY_LOCATIONS_SPEC = dict( license = "Apache-2.0", license_url = "https://github.com/census-instrumentation/opencensus-cpp/blob/{version}/LICENSE", ), - # This should be removed, see https://github.com/envoyproxy/envoy/issues/11816. + # Curl usage is under deprecation and will be removed by Q3 2024 before v1.31 release in July-2024. + # See https://github.com/envoyproxy/envoy/issues/11816 & https://github.com/envoyproxy/envoy/pull/30731. com_github_curl = dict( project_name = "curl", project_desc = "Library for transferring data with URLs", @@ -1082,7 +1083,6 @@ REPOSITORY_LOCATIONS_SPEC = dict( "envoy.filters.http.aws_lambda", "envoy.filters.http.aws_request_signing", "envoy.grpc_credentials.aws_iam", - "envoy.tracers.opencensus", ], release_date = "2023-10-11", cpe = "cpe:2.3:a:haxx:libcurl:*",