Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't overwrite dev build when building prod #18

Open
alex-wilmer opened this issue Aug 27, 2018 · 4 comments
Open

don't overwrite dev build when building prod #18

alex-wilmer opened this issue Aug 27, 2018 · 4 comments

Comments

@alex-wilmer
Copy link

alex-wilmer commented Aug 27, 2018

when running npm start the build folder is the root folder

when running npm build the build folder has child target folders which are builds for their target.

we talked about this before but I didn't quite understand the difference between build and dist. what do you think about having something like

  /build
    /dev
    /prod
      /chrome
      /firefox

I would also be okay with

  /build_dev
  /build_prod
@alex-wilmer
Copy link
Author

this also messes with the automated tests test:chrome since it's looking for a build target at a different level (assumes /build not /build/chrome

@alex-wilmer
Copy link
Author

few ways of solving this. I think a reasonable quick fix is passing a build target as a cli option

yarn build --build_dir build --target  chrome (by default chrome and ff are built)
yarn start --build_dir dev

@jbarzegar
Copy link

Couldn't we just do build for dev, and dist for a prod?

/build

/dist
	/chrome
	/firefox

This seems like the simplest option

@alex-wilmer
Copy link
Author

Why is naming the folder dist simpler? I think it's more confusing actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants