-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeArea
to Wirecloud
#537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a
CodeArea
styled element that is a full-fledged code editor supporting syntax highlighting of many languages and code completion of a few. Additionally, this allows the use ofCodeArea
as a preference type for widgets/operators (allowing to specify the language) as well asTextArea
.For this to be possible, the monaco editor has been used (MIT License), which is the same that VS Code uses (it is extracted from its source code). In case monaco fails to load, the CodeArea will be a simple
TextArea
.Types of changes
What types of changes does your code introduce to the project:
Checklist
Further comments
For monaco to be loaded, webpack has been used. A script was created so that a single command (docs in README) can build monaco and prepare it for Wirecloud.
This is still a work in progress, as tests are still missing.This is ready for review.Happy coding!