Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile #539

Merged
merged 13 commits into from
Jun 27, 2024
Merged

Dockerfile #539

merged 13 commits into from
Jun 27, 2024

Conversation

dmunozv04
Copy link
Contributor

@dmunozv04 dmunozv04 commented Mar 25, 2024

Proposed changes

Making docker builds easier by moving the dockerfile to the main repo

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

The dockerfile is tentatively using whitenoise to serve static assets without needing nginx or a similar tool. This can easily be reverted if deemed unsuitable. Reopening PR since the last one had changes from another branch by mistake

@coveralls
Copy link

Coverage Status

coverage: 88.257%. first build
when pulling ebf2a11 on dmunozv04:dockerfile
into 247b900 on Wirecloud:develop.

@coveralls
Copy link

Coverage Status

coverage: 88.257%. first build
when pulling 7d1b796 on dmunozv04:dockerfile
into 247b900 on Wirecloud:develop.

@coveralls
Copy link

Coverage Status

coverage: 88.269%. first build
when pulling adc9c85 on dmunozv04:dockerfile
into 247b900 on Wirecloud:develop.

@dmunozv04
Copy link
Contributor Author

dmunozv04 commented Jun 6, 2024

This PR takes the files from https://github.com/Wirecloud/docker-wirecloud and takes inspiration from https://github.com/dmunozv04/iSponsorBlockTV to build docker files with GitHub Actions.
It also checks the tests on docker-platform/tests.py
The only thing that's needed before merging is adding the following secrets to the repo:

  • DOCKERHUB_USERNAME
  • DOCKERHUB_TOKEN

@coveralls
Copy link

Coverage Status

coverage: 88.263%. first build
when pulling 28ba5a8 on dmunozv04:dockerfile
into b197d37 on Wirecloud:develop.

@coveralls
Copy link

Coverage Status

coverage: 88.257%. first build
when pulling 032eb85 on dmunozv04:dockerfile
into b197d37 on Wirecloud:develop.

@aarranz aarranz merged commit 8d8c4b4 into Wirecloud:develop Jun 27, 2024
37 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants