Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improves the way of loading v2 widgets and operators.
Changes:
entrypoint
is optional.Wirecloud.registerWidgetClass(script, class)
andWirecloud.registerOperatorClass(script, class)
. Both receive the current script element of the DOM, accessible bydocument.currentScript
, and the class entrypoint of the widget (the one that receives the MashupPlatform).With these changes, the window object does not have to be polluted with widgets and operators defining their class in it, which also helps to prevent conflicts between them. The other way of loading them, with the
entrypoint
configuration, still works.Along with this PR, more will be done in the grunt-init and config-parser repositories.
Types of changes
What types of changes does your code introduce to the project: Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
None