Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PGE File Library support from Kevsoft's "experimental-reader" branch #22

Open
Wohlstand opened this issue May 8, 2018 · 5 comments
Assignees

Comments

@Wohlstand
Copy link
Member

Wohlstand commented May 8, 2018

Some times ago Kevsoft have made an experiment to use PGE File Library instead of built-in LVL file parser. It possibly works fine in a pure engine runtime, but it works very clunky when it's running from the SMBX Editor.

It's need to take most of Kevsoft's changes and polish the whole stuff to make it be working.

@Bluenaxela
Copy link
Contributor

Bluenaxela commented May 8, 2018

  1. experimental-npcid-extension (now changed to a tag) has been merged to master so that master will be the current mainstream branch.

  2. experimental-reader-updated has been created, from the combination of latest latest master and experimental-reader. This resolves all merge conflicts and the merged result builds successfully. It still has a very old PGE File Library though.

@Wohlstand
Copy link
Member Author

Wohlstand commented May 8, 2018

  1. Okay
  2. Yeah, therefore is needed to put the PGE File Library as submodule or ExternalProject of CMake build.
    I'll check out the whole stuff at evening, for this moment it's morning and 9:46 AM.

@Bluenaxela
Copy link
Contributor

Bluenaxela commented May 8, 2018

Agreed. I just did a merge as a first step, which makes it easier to look at the changes experimental-reader had made in the context of the up-to-date code. Good to to have a proper merge that builds correctly without extra done beyond what was strictly necessary to build. Changing the PGE File Library to a submodule or something can be the next step.

@Wohlstand
Copy link
Member Author

Wohlstand commented May 14, 2018

The support for level files is almost completed, the one thing is still need is:

  • On side of PGE Editor fix a crash of LunaTester that unreasonable happens after level testing launch
  • Implement Lua binding for PGE-FL to dump files as lua-table trees
  • Implement NPC-*.txt replacement to use PGE-FL
  • Implement World Maps replacement to use PGE-FL

@Wohlstand
Copy link
Member Author

Basic PGE File Library has been added!

@Wohlstand Wohlstand assigned Emral and Saturnyoshi and unassigned Wohlstand Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants