Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an alternative format of banks.ini to allow easier remove/reorder of banks without dealing with ordered numbers #253

Open
mmontag opened this issue Mar 14, 2022 · 5 comments

Comments

@mmontag
Copy link
Contributor

mmontag commented Mar 14, 2022

A while back you said bank IDs in the banks.ini need to be continuous (e.g., [bank-0], [bank-1], [bank-2], etc.) but this makes banks.ini hard to edit (well, in my case... I won't touch it).

Any chance to fix this quirk?

@Wohlstand
Copy link
Owner

You could make a new, your own, banks.ini file and supply it as CMake argument, you don't need to take my original one and inherit it for your needs, you can just make yor own one. It should work.

@Wohlstand
Copy link
Owner

I also forgot to note: that original banks.ini file is designed to hardly link ID of each bank, because IDs of every bank should not being changed during removing of any bank from the middle. That's required for backward compaitibility with software that expects certain built-in bank ID for the use instead of using the supplied WOPL file.

@Wohlstand Wohlstand changed the title banks.ini is hard to edit Implement an alternative format of banks.ini to allow easier remove/reorder of banks without dealing with ordered numbers Nov 25, 2023
@Wohlstand
Copy link
Owner

Anyway, a question: is this still being needed?

@Wohlstand Wohlstand self-assigned this Nov 25, 2023
@mmontag
Copy link
Contributor Author

mmontag commented Nov 26, 2023

Thanks, you can close based on your advice to create my own banks.ini. However, my-custom-banks.ini is still hard to edit, so I wish the bank ID number was optional/implicit.

@Wohlstand
Copy link
Owner

Again, the reason why bank id is required - to ensure the full backward compatibility between previous versions (supposed to don't pop entries from a middle, but replace them with others without breaking a count, or append new to end of the whole list, again, to preserve previous IDs being not changed). I can understand if you trying to re-order banks according your tastes or ideas, and this concept needs a different thing, so, I can agree. Alternative solution: you may want to convert all banks into WOPL format, and then, supply each of them via adl_openBankData() call rather than use embedded banks (you may want to completely disable use of embedded banks then [by related CMake argument]).
I'll remain this open and I'll try to implement a kind of the second format (I'll add the field into header section to specify what format should be used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Maybe later
Development

No branches or pull requests

2 participants