Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS prefixing check #930

Closed
dingo-d opened this issue Apr 11, 2017 · 2 comments
Closed

JS prefixing check #930

dingo-d opened this issue Apr 11, 2017 · 2 comments

Comments

@dingo-d
Copy link
Member

dingo-d commented Apr 11, 2017

Building on #907, a similar check should be made for JavaScript functions.

Atm the only thing that I can think of is creating a custom lint, that should be then added along with the WPTRT 120 issue, for general line check.

@jrfnl
Copy link
Member

jrfnl commented Apr 11, 2017

@dingo-d FYI: PHPCS already contains a tokenizer for JS as well. It's not as fully featured as the PHP one, but I got a suspicion that it shouldn't be hard to create a "normal" PHPCS sniff for this (or add to the PrefixAllGlobals one).

@jrfnl
Copy link
Member

jrfnl commented Dec 2, 2022

With an eye on PHPCS dropping support for JS in PHPCS 4.0 and most of the JS checking having moved to ESLint now anyway, I suggest closing this as wontfix.

@jrfnl jrfnl closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants