-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin-sidebar-9ee4a6 to match the example explained at How-to Guides- Plugin Sidebar #66
Comments
@juanmaguitar greetings! I was doing some investigating about the differences in code here, there's two main differences between it and @ryanwelcher's code. The links on the post above are broken, probably because the test site has been merged into production. But here are the corrected links:
Observations
Relevant PR with How To guide codePossible fix: Add the no-build example to this repoThat said, it could be possible to add the example code from the field guide to the Caveat(s)The only thing is, the code is very different, so I'm not sure if this would be more confusing. Also it's possible the code on the How To guide is out of date. Please let me know what you all think! Best/Seth |
Hi @flexseth, thanks a lot for the detailed report on this issue. |
@juanmaguitar Hope your holiday was great! I think I misunderstood what you were requesting! If this is the case, I'd be happy to update the docs to reflect @ryanwelcher's code. Thanks for taking a look! |
@ryanwelcher - do you mind assigning this to me so I can more easily search it when looking for issues to work on, please! TYIA |
Update plugin-sidebar-9ee4a6 to recreate with JSX the example explained in Block Editor Handbook - How-to Guides- Plugin Sidebar
Once is published, update the Block Editor Handbook - How-to Guides- Plugin Sidebar to match the code snippets with the code of this example
The text was updated successfully, but these errors were encountered: