-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "Template Parts" list with area-based alternative #36613
Comments
I like the simplicity of showing only header and footer, it looks nice. The problem I see is user created template parts.
I think that is why the template part area setting is under the Advanced panel. If the general template parts are only accessible through templates, how are they deleted? It is not enough to only select and delete the block in place in the editor. |
The icons look really nice though 😄 |
We can try adding the icons too, but I suspect that would involve edits to the underlying component and so might be better handled separately? |
Here's a PR that tackles adding the icons - #36893 |
Should this still be done or should it be closed? I see that the main tracking issue #36597 is closed. |
I think there's a decent argument for this change, if it's simple enough to implement. Not a strong opinion though, because it's unclear if this particular UI will persist in the long term (see #39885). |
Closing this out as the interface has evolved immensely, including a "Patterns" section with template parts listed. What remains for consideration is this issue around emphasizing header/footer more: #50958 |
Part of #36597
The Template Parts list works well:
However, "Template Parts" is a fairly technical term that we arguably shouldn't be surfacing unless absolutely necessary. Since template parts can be associated with specific areas, we might use those to refine the navigation:
The main drawback here is that "general" template parts would only be accessible through templates directly.
cc @kellychoffman
The text was updated successfully, but these errors were encountered: