ToolsPaneltem: Stale hasValue when value is reset by different means

[Mamaduka]

ToolsPaneltem: Stale hasValue when value is reset by different means

While working on #55973, I noticed that when you reset the image from MediaReplaceFlow, the tools panel still shows the reset option.

I can reproduce it on the trunk, so it's probably a different issue with the tools panel.

Originally posted in #55973 (comment)

Screencast

CleanShot.2023-11-08.at.19.50.44.mp4

[Mamaduka]

@andrewserong, let's move our ToolsPanel convo here.

In the screencast at 0:03, you will see that both tools panel options are active after resetting the image via MediaReplaceFlow. I would expect those to be disabled and non-actionable.

[andrewserong]

Thanks for raising this separately! I imagine it's probably an issue with the ToolsPanel as I can reproduce a similar kind of issue with typography in global styles. As an example, if we go to change the appearance and set a value, then set it back to default, the panel still thinks there's a value:

2023-11-09.16.10.48.mp4

Similarly, in the block editor, if we go to set a custom font size, and then clear out the value so that it matches the default state, the ToolsPanel still thinks there's a value there:

2023-11-09.16.08.19.mp4

So it feels like perhaps in the ToolsPanel there's possibly some stale logic in checking for hasValue, as you mention.

[stokesman]

I believe this has been resolved by #60621. I tested a couple of the demonstrated cases in this issue and cannot reproduce them.

[Mamaduka]

Thanks for testing, @stokesman! I can also confirm that the reported bug is gone.

I'll close the issue.