Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove font weight on toolbar tab button #61254

Closed
richtabor opened this issue Apr 30, 2024 · 2 comments
Closed

Remove font weight on toolbar tab button #61254

richtabor opened this issue Apr 30, 2024 · 2 comments
Labels
[Block] HTML Affects the the HTML Block General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

After reviewing #46834 I noticed the Edit and Preview controls in the HTML block's toolbar are set to 500 font weight (source), where all other text based toolbar controls are not (like the "Replace" button on Image block).

I propose we remove the font weight applied to these, for consistency across toolbar controls:

CleanShot 2024-04-30 at 10 14 50
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time General Interface Parts of the UI which don't fall neatly under other labels. [Block] HTML Affects the the HTML Block labels Apr 30, 2024
@richtabor richtabor added this to Polish Apr 30, 2024
@hbhalodia hbhalodia mentioned this issue May 2, 2024
Merged
@hbhalodia
Copy link
Contributor

Hi @richtabor, I have raised the PR for the same - #61308

Thank You.

t-hamano added a commit that referenced this issue May 3, 2024
@hbhalodia @t-hamano
Fix: Remove font weight on toolbar tab button - #61254 (#61308)
cbee699 
* Fix: remove the font weight from the toolbar button to make it consistent with other toolbars

* Removed the unused style for the toolbar button

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: jasmussen <[email protected]>
@t-hamano
Copy link
Contributor

t-hamano commented Jun 2, 2024

Fixed by #61308

@t-hamano t-hamano closed this as completed Jun 2, 2024
@github-project-automation github-project-automation bot moved this to Done in Polish Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] HTML Affects the the HTML Block General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
Polish
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richtabor @t-hamano @hbhalodia