Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter / List View: Refactor panels to use the same code #61549

Closed
scruffian opened this issue May 10, 2024 · 5 comments
Closed

Inserter / List View: Refactor panels to use the same code #61549

scruffian opened this issue May 10, 2024 · 5 comments
Labels
[Feature] Zoom Out [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

What problem does this address?

Right now the inserter sidebar and the list view share a lot of functionality but are different code bases. We'd like to ensure that they offer the same affordances and UX.

What is your proposed solution?

We should refactor these panels to use the same code so that each benefits from improvements to the other and we have a consistent experience.

@alexstine
Copy link
Contributor

So to be 100% clear, we're talking same code loading different conditional components? Not talking say the inserter and list view in the same sidebar UI at the same time?

Thanks.

@jeryj
Copy link
Contributor

jeryj commented May 10, 2024

So to be 100% clear, we're talking same code loading different conditional components?

Yes. It's just about making the wrapping components share the same code and hook-up the similarities like managing focus between the button that opens it and closes, and maybe adding the tabs. The UI of everything would stay as it is today.

@alexstine
Copy link
Contributor

I do have concerns about another level of tabs though. We'd be left with a very complex experience in having to select the block inserter, patterns, then a category. Just something to keep in mind before this train goes off the rails. Not an explicit accessibility failure, but could be a not great UX.

@jeryj
Copy link
Contributor

jeryj commented May 10, 2024

Sorry this has been confusing to communicate. We're not changing the current UI in any way with this idea. Only refactoring code to be easier to maintain. There should not be any functional change to the semantics or interactions.

@scruffian
Copy link
Contributor Author

This was fixed in #62343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Enhancement A suggestion for improvement.
Projects
Development

No branches or pull requests

3 participants