Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query loop: Clarify the Max page to show setting #63028

Open
afercia opened this issue Jul 1, 2024 · 0 comments
Open

Query loop: Clarify the Max page to show setting #63028

afercia opened this issue Jul 1, 2024 · 0 comments
Labels
[Block] Query Loop Affects the Query Loop Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 1, 2024

Description

Noticed while working on Discovered while working on #63020

In the Query loop block, the 'Items per page', 'Offset', and 'Max page to show' settings are grouped together.
Currently, they're in a popover that opens from the block toolbar. In #63020 they will be moved to the Inspector panel.

Regardlessof their overall placement, I'm not sure these settings should be grouped together.

  • 'Items per page' and 'Offset' are more related to the Query properties.
  • 'Max page to show' is more related to the Pagination links.

As a useer, the 'Max page to show' setting isn't immediately clear to me. I'd tend to think this setting should be better placed, probably in its own section as suggested also by @carolinan
Also, the descriptiokn:

Limit the pages you want to show, even if the query has more results. To show all pages use 0 (zero).

doesn't clearly explain this setting is about the pagination links. While 'pagination' may be a technical term to avoid, I'd think this setting should be better explained.

Nnte: in #63020 I'm fixing also a setting name typo where I guess 'page' should be plural 'pages' -> 'Max pages to show'.

Step-by-step reproduction instructions

  • Add a Query loop block > Start blank > Title & date.
  • Click 'Display settings' in the block toolbar.
  • Note: after Make usage of the settings icon more consistent #63020 these settings will be placed in the Inspector panel.
  • Observe the 'Max page to show' setting is grouped together with 'Items per page' and 'Offset'.
  • Observe both the setting name and its description don't clarify very well this setting is related to the pagination links.

Screenshots, screen recording, code snippet

Screenshot 2024-07-01 at 15 41 32

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Block] Query Loop Affects the Query Loop Block labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant