-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Views: Rename 'View Options` control to 'Screen Options' #63029
Comments
To me it looks like the problem came from the word "view" being understood as a verb, rather than a noun - a common issue when creating strings. Instead of changing the string, I'd recommend adding context that makes it clear that "View" is used as a noun here. We have similar cases with the "View" word already, FWIW, which is why I'm recommending this approach:
This change would invalidate the translation and make it fuzzy, so the translators should fix it now that it has the right context. I've also suggested that in #63031 which attempts to fix this issue. |
Yes the context parameter could help. Screenshot for references: Cc @WordPress/gutenberg-design |
View options reads substantially clearer to me, as it's affecting your view. |
Le me try to be more clear.
|
I feel like what's currently suggested in #63031 is the best compromise, and it will help fix the original issue, which to me is mostly a mistranslation problem. I personally consider this a different setting, and not necessarily correlating to the "Screen options" we have in the original admin. So I don't view this as a change, but rather as a new string for a new use case. I may be a bit biased by my native tongue (but maybe not, because I have lots of experience with translation, as a matter of fact I'm currently a General Translation Editor for Bulgarian), but in Bulgarian, "View" and "Screen" have very different meanings ("изглед" and "екран") and "View" does make more sense in this context. I won't argue about the validity of the pre-existing core "Screen options" string, since it's been there forever, but to me, it's a clear indication that "View" is better even in that context, because even "Screen options" is currently being translated as "Настройки на изгледа", which actually translates more accurately as "View options" in English (consider that "screen" is still "екран" according to the official Bulgarian glossary). Another reason why I feel View makes more sense is because there eventually may (and will) be multiple views on the same screen, and then "Screen options" just won't make sense from a functional or user experience perspective. Just my 2 cents, of course. |
Although not fully implemented, it's also worth noting that users will eventually be able to add/manage custom views. To that extent the "View options" label has contextual meaning – it provides access to options for the current view. "Custom screens" doesn't read very well to me. |
I also vote to keep the "View option" and add context. The word "View" feels more fitting for something more dynamic and reactive, like Google Maps Street View, so I feel like this word is appropriate for the Data Views too. |
Description
In the Data Views, the icon button of the fropdown with the settings for layout, sorting, etc. is labeled 'View Options`. Screenshot:
I'd argue the label could be improved as there's at least a couple issues:
1
It isn't very clear whether it means 'options of the view' or 'see the options'. This lack of clarity is clearly reflected in some translations. I only checked two translations: Spanish and Italian. They bot translate to the equivalent of 'see the options'. Screenshots:
I'm not sure this is a transnlators responsibility, I wouldn't blame them for this. Rathger, the labeling is unnecessarily unclear and could be improved.
2
Historically, in the WordPress admin, the equivalent section with settings for the list tables is called 'Screen Options`. This is a pretty familiar terminology because it has been used for years. I don't see a good reason to change it to 'View Options'. Considering that the data views in the future will be used more and more in the admin, I'd recommend to consider a more familiar, unambigous, simpler labeling. 'Screen Options' seems to me the best option.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: