Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Views: Rename 'View Options` control to 'Screen Options' #63029

Open
afercia opened this issue Jul 1, 2024 · 7 comments · May be fixed by #63031
Open

Data Views: Rename 'View Options` control to 'Screen Options' #63029

afercia opened this issue Jul 1, 2024 · 7 comments · May be fixed by #63031
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). l10n Localization and translations best practices Needs Design Feedback Needs general design feedback. [Package] DataViews /packages/dataviews [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 1, 2024

Description

In the Data Views, the icon button of the fropdown with the settings for layout, sorting, etc. is labeled 'View Options`. Screenshot:

english

I'd argue the label could be improved as there's at least a couple issues:

1
It isn't very clear whether it means 'options of the view' or 'see the options'. This lack of clarity is clearly reflected in some translations. I only checked two translations: Spanish and Italian. They bot translate to the equivalent of 'see the options'. Screenshots:

spanish
italian

I'm not sure this is a transnlators responsibility, I wouldn't blame them for this. Rathger, the labeling is unnecessarily unclear and could be improved.

2
Historically, in the WordPress admin, the equivalent section with settings for the list tables is called 'Screen Options`. This is a pretty familiar terminology because it has been used for years. I don't see a good reason to change it to 'View Options'. Considering that the data views in the future will be used more and more in the admin, I'd recommend to consider a more familiar, unambigous, simpler labeling. 'Screen Options' seems to me the best option.

Step-by-step reproduction instructions

  • Go to the Site Editor > Pages.
  • At the top of the pages list, hover or focus the View Options icon button.
  • Observe the button label is... View Options.
  • test with languages other than English, Spanish or Italian and please report in the comments below all the incorrect translations you may find.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. l10n Localization and translations best practices [Package] DataViews /packages/dataviews labels Jul 1, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 1, 2024
@tyxla
Copy link
Member

tyxla commented Jul 3, 2024

To me it looks like the problem came from the word "view" being understood as a verb, rather than a noun - a common issue when creating strings. Instead of changing the string, I'd recommend adding context that makes it clear that "View" is used as a noun here.

We have similar cases with the "View" word already, FWIW, which is why I'm recommending this approach:

<MenuGroup label={ _x( 'View', 'noun' ) }>

This change would invalidate the translation and make it fuzzy, so the translators should fix it now that it has the right context.

I've also suggested that in #63031 which attempts to fix this issue.

@afercia
Copy link
Contributor Author

afercia commented Jul 4, 2024

Yes the context parameter could help.
I'd like to have some design feedback though. In the future, the data views are expected to replace the classic admin pages based on list tables. For years, the UI with settings for these pages has been called 'Screen Options`. I'd rather keep this name because it's the most familiar for users. What is the added value in changing it to 'View Options'? How this change helps users?

Screenshot for references:

Screenshot 2024-07-04 at 08 37 40

Cc @WordPress/gutenberg-design

@jasmussen
Copy link
Contributor

View options reads substantially clearer to me, as it's affecting your view.

@afercia
Copy link
Contributor Author

afercia commented Jul 4, 2024

View options reads substantially clearer to me, as it's affecting your view.

Le me try to be more clear.

  • Users are used to the 'Screen Options' terminology.
  • Why we have to change it?
  • Unnecessary changes should be avoided or, at least, be A/B tested to validate they are actual improvements.

@tyxla
Copy link
Member

tyxla commented Jul 4, 2024

I feel like what's currently suggested in #63031 is the best compromise, and it will help fix the original issue, which to me is mostly a mistranslation problem.

I personally consider this a different setting, and not necessarily correlating to the "Screen options" we have in the original admin. So I don't view this as a change, but rather as a new string for a new use case.

I may be a bit biased by my native tongue (but maybe not, because I have lots of experience with translation, as a matter of fact I'm currently a General Translation Editor for Bulgarian), but in Bulgarian, "View" and "Screen" have very different meanings ("изглед" and "екран") and "View" does make more sense in this context. I won't argue about the validity of the pre-existing core "Screen options" string, since it's been there forever, but to me, it's a clear indication that "View" is better even in that context, because even "Screen options" is currently being translated as "Настройки на изгледа", which actually translates more accurately as "View options" in English (consider that "screen" is still "екран" according to the official Bulgarian glossary).

Another reason why I feel View makes more sense is because there eventually may (and will) be multiple views on the same screen, and then "Screen options" just won't make sense from a functional or user experience perspective.

Just my 2 cents, of course.

@jameskoster
Copy link
Contributor

Although not fully implemented, it's also worth noting that users will eventually be able to add/manage custom views. To that extent the "View options" label has contextual meaning – it provides access to options for the current view.

"Custom screens" doesn't read very well to me.

@t-hamano
Copy link
Contributor

t-hamano commented Jul 4, 2024

I also vote to keep the "View option" and add context.

The word "View" feels more fitting for something more dynamic and reactive, like Google Maps Street View, so I feel like this word is appropriate for the Data Views too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). l10n Localization and translations best practices Needs Design Feedback Needs general design feedback. [Package] DataViews /packages/dataviews [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants