Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Caption to Gallery Images within Block is impractical. #6858

Closed
bahia0019 opened this issue May 21, 2018 · 3 comments
Closed

Add Caption to Gallery Images within Block is impractical. #6858

bahia0019 opened this issue May 21, 2018 · 3 comments
Labels
[Feature] Media Anything that impacts the experience of managing media [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@bahia0019
Copy link

Describe the bug
Playing around with Gallery block, I noticed you can add Captions without launching the Media Modal.
However, it seems too impractical to be a viable method of adding caption.
Long captions completely take over the photo, making it impossible to recognize which photo it is.

To Reproduce
Steps to reproduce the behavior:

  1. Insert photos into a Gallery block.
  2. Hover over individual photo to see the "Add Caption."
  3. Write any caption you like, and see the text overfloweth.

Possible Solution
In the new Image block, I love the ability for text to be styled and links to be created.
I think a possible solution here is:

  1. Create a gallery of images.
  2. Select individual image (maybe an icon in lower right).
  3. Image expands to and looks like Image Block.
  4. Caption can be filled out similarly to Image Block.
  5. Click icon to save.
  6. Image zooms back to small thumbnail.

The other option is to just not have ability to add captions in Gallery block, and leave it in the Media Modal only.

Screenshots
screen shot 2018-05-20 at 5 57 52 pm

@mtias mtias added [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media labels Jun 22, 2018
@BinaryMoon
Copy link

Related to this - the toolbar is not visible. It just all looks a bit broken to me.

screen shot 2018-07-03 at 12 00 28

@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Jul 19, 2018
@kjellr kjellr mentioned this issue Jul 30, 2018
12 tasks
@nerrad
Copy link
Contributor

nerrad commented May 26, 2019

Related to this - the toolbar is not visible. It just all looks a bit broken to me.

I'm not seeing this issue.

However, it seems too impractical to be a viable method of adding caption.

I'm not sure what the issue is here. Is the request that images in galleries should not show captions or that any captions should not overlay the images?

One issue with making changes to this block after a year of it being in the wild is some sites might be used to and using the current behaviour, so any changes could make will disrupt those use-cases.

One thing I do notice is that entering a caption on the image in the gallery does not persist that so it's attached with the image when viewing through the media modal. Also, if you update a caption in the media modal it clears any captions added via the block editor (which I see is being worked on in #15004)

This also appears to be a function of theme design (so depends on how themes display the captions for images).

There's some related discussions in the following pulls/issues (related in terms of gallery captions):

In light of the above and the staleness of this issue I'm going to close this for now. It does appear captions are being worked on in the meantime and this issue certainly can be re-opened.

@nerrad nerrad closed this as completed May 26, 2019
@bahia0019
Copy link
Author

Yes, the issue is about the cludgy UI when the captions are overlaid on the image. I do like that look on the frontend, but when you have a narrow area, it just looks terrible (Yes, these are unusually long in the example).
Personally, I think a text field below each photo would suffice for this.

Screen Shot 2019-05-25 at 7 06 03 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants