Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop loading homepage image gallery on smaller screens #2605

Closed
obulat opened this issue Jul 11, 2023 · 2 comments
Closed

Stop loading homepage image gallery on smaller screens #2605

obulat opened this issue Jul 11, 2023 · 2 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🔧 tech: vue Involves Vue.js

Comments

@obulat
Copy link
Contributor

obulat commented Jul 11, 2023

Problem

Openverse homepage loads all of the homepage images even on small screens, where the images are never shown.

Description

Currently, we use tailwind classes to show the homepage gallery on xl breakpoint: hidden xl:flex.
Instead, we should use the Vue's v-if to conditionally render the component only on the xl screens and up.

<script>
.....
const isXl = computed(() => uiStore.isBreakpoint("xl"))
...
</script>
<template>
...
<VHomeGallery v-if="isXl" class="h-full flex-grow flex" />
...
@obulat obulat added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🔧 tech: vue Involves Vue.js labels Jul 11, 2023
@ibrijesh
Copy link

I would like to contribute can you please assign me.

@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Jul 12, 2023
@obulat
Copy link
Contributor Author

obulat commented Jul 19, 2023

Hi, @ibrijesh! I'm sorry but this issue was fixed in #2674. It was a small change in the files that that PR touched.

Could you please select a different "help wanted" issue?

@obulat obulat closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🔧 tech: vue Involves Vue.js
Projects
Archived in project
Development

No branches or pull requests

2 participants