Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the image proxy route to async #2789

Closed
sarayourfriend opened this issue Aug 7, 2023 · 1 comment · Fixed by #3388
Closed

Convert the image proxy route to async #2789

sarayourfriend opened this issue Aug 7, 2023 · 1 comment · Fixed by #3388
Assignees
@sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API 🔒 staff only Restricted to staff members
Milestone
Django ASGI

Comments

@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Aug 7, 2023 •
edited
Loading

Description

Convert the image proxy (thumbnail) route to async.

Should be done in 2 PRs:

  1. Get the view async compatible using ADRF
  2. Async-ify image_proxy.get

Additional context

Marked "staff only" due to complexity and ambiguity.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 💻 aspect: code Concerns the software code in the repository 🔒 staff only Restricted to staff members 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API labels Aug 7, 2023
@sarayourfriend sarayourfriend added this to the Django ASGI milestone Aug 7, 2023
@sarayourfriend sarayourfriend mentioned this issue Aug 7, 2023
Closed
@sarayourfriend sarayourfriend mentioned this issue Sep 8, 2023
Closed
7 tasks
@sarayourfriend
Copy link
Collaborator Author

This issue is now much simpler since the latest ADRF version supports views with mixed sync and async handlers. That means we don't need to arbitrarily split async routes into a different viewset! 🎉

@sarayourfriend sarayourfriend mentioned this issue Sep 13, 2023
Merged
7 tasks
@sarayourfriend sarayourfriend mentioned this issue Nov 2, 2023
Closed
2 tasks
@sarayourfriend sarayourfriend changed the title Convert the image proxy route to an async view running under WSGI Convert the image proxy route to async Nov 16, 2023
@sarayourfriend sarayourfriend mentioned this issue Nov 22, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API 🔒 staff only Restricted to staff members
Projects
Openverse Backlog
Archived in project
Milestone
Django ASGI
Development

Successfully merging a pull request may close this issue.

Convert entire image proxy route async WordPress/openverse
1 participant
@sarayourfriend