Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete previous project reminder comment before issuing a new one #2836

Closed
AetherUnbound opened this issue Aug 15, 2023 · 2 comments
Closed
Assignees
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations

Comments

@AetherUnbound
Copy link
Collaborator

Description

In #2251 we added logic for issuing a reminder to post an update in project threads that match our standard "open" states. This reminder bot does not delete existing project thread comments before posting a new one, which can leave multiple duplicate comments in a row if a prompt is not addressed. Example: #2545

Similar to the logic we have for the Playwright failure comments, we should also delete the existing comment calling for an update on a project thread before issuing a new one.

@AetherUnbound AetherUnbound added 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Aug 15, 2023
@sarayourfriend
Copy link
Collaborator

@AetherUnbound Can you share more about why this behaviour is undesirable or why it's high enough priority to work on now? It only happens in a very specific edge case and, frankly, it's one that I think we should have documented in the project. It only happens if a project goes an entire month or more without any updates to the project thread. My understanding of why we do project thread updates in the first place would suggest to me that we actually want to be able to clearly see that there were no updates, but that a reminder did happen, to document that (a) there was some breakdown in priorities that caused us not to post an update to that project thread and (b) to add an extra prompt for the next project update to include the entire missed period, particularly including any explanation of why/if the project was stalled (which seems like the most common reason why we would miss a project updated).

Maybe there is a different way to approach this? I think it's actually valuable to have those multiple pings and considering the case where they happen is rare but still significant just collapsing the reminders doesn't feel like a solution to me (not just because I'm sceptical that there's a problem with it to begin with, but also because it really does hide potentially important information).

@AetherUnbound
Copy link
Collaborator Author

@sarayourfriend thanks for your thoughts! I think I was erroneously conflating the urgency of this situation with feedback folks have provided in the past about the PR review request reminders. I was considering the use case for both situations to be the same, but I agree that seeing multiple update-request comments on a project thread does provide useful information about a breakdown somewhere. An additional prompt on a second-in-a-row update request might be good, but is certainly not something that would require any urgency looking into. Multiple PR review reminders left in a PR is noise, but it isn't for the project threads. I'll go ahead and close this issue then 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

No branches or pull requests

2 participants