-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean repeated static string interpolation #5261
base: main
Are you sure you want to change the base?
Clean repeated static string interpolation #5261
Conversation
Hi @tejaswarathe! Great work on this PR! Is anything blocking you? It seems that you only need to run lint. Let us know if you need any help with anything. |
Hi @obulat, Yes I was stuck with the same lint issue and was also travelling for past few days. Will check again today to fix it and push changes. |
Fixes
Fixes #4980 by @sarayourfriend
Description
The changes here is to remove the repeated interpolation strings as mentioned in #4980
I have changed the method replacer() in translations.mjs which is used to replace the string with {} brackets while the pot files are converted to json for each language from Glotpress.
I have also added an object targetWords where we can add the world which we do not want to translate. Further work required is just to change the en.json5 file and change the strings like
_{github}_
to_{'github'}_
and adding that string to targetWords object. This will make sure that the translations also will keep the string within single quotes ('') to consider them as string literal.Currently the changes have only been done for
openverse
string.Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin