Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thumbnail_url for thumbnail generation when present #677

Closed
1 task
stacimc opened this issue Aug 24, 2022 · 1 comment
Closed
1 task

Use thumbnail_url for thumbnail generation when present #677

stacimc opened this issue Aug 24, 2022 · 1 comment
Labels
🧱 stack: api Related to the Django API

Comments

@stacimc
Copy link
Collaborator

stacimc commented Aug 24, 2022

Problem

Some providers (like SMK) may link to quite large images in their image_url. This can cause unacceptably slow response times or even timeouts when generating thumbnails via our thumbnail service.

Description

We already have a thumbnail_url available on the Image model which we can use.

When the thumbnail_url is available, we should send this to the thumbnail service instead of the image_url. This should be a small change here:

image_url = image.thumbnail or image.url

(using the serialized field names)

Additional context

#1450 tracks updating the SMK provider script in the Catalog to populate thumbnail_url with a link to a smaller image size.

Implementation

  • 🙋 I would be interested in implementing this feature.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@krysal krysal added 🧱 stack: api Related to the Django API and removed 🧱 stack: backend labels Mar 7, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@krysal
Copy link
Member

krysal commented Apr 21, 2023

Duplicate of #675.

@krysal krysal closed this as not planned Won't fix, can't repro, duplicate, stale Apr 21, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 21, 2023
This issue is being transferred. Timeline may not be complete until it finishes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧱 stack: api Related to the Django API
Projects
Archived in project
Development

No branches or pull requests

3 participants