Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 2.9.0 release #985

Closed
3 tasks done
eclarke1 opened this issue Feb 13, 2024 · 6 comments · Fixed by #992 or #1001
Closed
3 tasks done

Prepare 2.9.0 release #985

eclarke1 opened this issue Feb 13, 2024 · 6 comments · Fixed by #992 or #1001
Assignees
Labels
Infrastructure Issues for the overall performance plugin infrastructure

Comments

@eclarke1
Copy link

eclarke1 commented Feb 13, 2024

This issue is to track preparation of the upcoming 2.9.0 release up until publishing, which is due February 20, 2024.

  • Create release/2.9.0 branch closer to the release date
  • Finalize scope and punt unfinished pull requests to following release
  • Prepare the release (Tuesday February 20, 2024)
@eclarke1 eclarke1 added the Infrastructure Issues for the overall performance plugin infrastructure label Feb 13, 2024
@eclarke1 eclarke1 added this to the PL Plugin 2.9.0 milestone Feb 13, 2024
@eclarke1
Copy link
Author

@joemcgill @westonruter did we manage to create this branch so we can commence testing today? Also updating the date here to be Tuesday Feb 20

@joemcgill
Copy link
Member

The branch is ready, but I'm reviewing why unit tests are currently failing.

@joemcgill
Copy link
Member

Looks like the Unit Test failures showing in the branch are inaccurate and are pointing to the wrong commit in our repo. Regardless, I set up a way to manually trigger these in #990 and am porting them to the 2.9.0 branch (#991), which will also re-trigger the test workflow.

@joemcgill
Copy link
Member

joemcgill commented Feb 15, 2024

Prepped the PR for the release ☝🏻, which we won't merge until the release party.

@westonruter
Copy link
Member

westonruter commented Feb 15, 2024

Testing instructions for what's new in this release:

  1. Make sure that Auto Sizes and Speculation Rules plugins are listed on the settings screen and that the plugins can be installed (PR).
  2. Install the plugin on a read-only filesystem (see disable-file-mods.zip mini plugin) and make sure that the messages for installing the standalone plugins make sense (issue).
  3. When standalone plugins have been installed, make sure they appear in the PL generator tag (PR).
  4. On Tools > Server-Timing, enable output buffering and add render_block_core/site-logo to the list of filters that are timed, and make sure that this shows up in the Server-Timing when accessing the page (issue).

@westonruter
Copy link
Member

My testing:

  1. Check out update/2.9.0-release-prep
  2. Run git archive --output performance-lab.zip HEAD
  3. Spin up a new WP site at https://wp.new/
  4. Upload the performance-lab.zip to the site and activate

Now for testing what is new:

For points 1 & 2, I can see that the new plugins are listed and when file mods are disabled, the installation buttons and messages are modified:

File Mods Enabled File Mods Disabled
Screenshot 2024-02-15 13 58 06 Screenshot 2024-02-15 14 12 47

Note the plugin assets for Auto Sizes and Speculation Rules will be updated before.

For the generator tag, I activated all of the plugins and I see them listed as expected:

<meta name="generator" content="Performance Lab 2.9.0; modules: images/webp-support; plugins: webp-uploads, dominant-color-images, performant-translations, auto-sizes, speculation-rules">

In regards to Server-Timing, I am able to see the render_block_core/site-logo timing now show up:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants