Add multisite support for admin page

[felixarntz]

Is your enhancement related to a problem? Please describe.

The admin screen from #32 and the plugin action link from #36 are not fully working in multisite yet, or rather, they are limited to the individual site's WP Admin UI. We should expand that so that the same admin screen works in the Network Admin UI as well.

This is particularly critical, since on some multisite configurations regular administrators are not allowed to control plugins.

Acceptance Criteria

• The admin page class from Create Tools page #32 should be expanded to also add the same admin screen on the network_admin_menu action hook.
  • The admin page added can behave the same way for now, but since the "Tools" menu does not exist in the Network Admin, we should add the screen in the "Settings" menu there (i.e. use add_submenu_page() with settings.php).
• The plugin action links from Introduce a “Check this plugin” link in the Plugins list table #36 should be expanded to also show up in the Network Admin via the network_admin_plugin_action_links filter.
  • Particular attention has to be paid to the URL, since the page lives under settings.php here (instead of options-general.php in the regular WP Admin).

Test Coverage

• Ensure the admin page is added propertly when using the Network Admin specific action.
• Ensure the plugin link is added properly when using the Network Admin specific filter.

[felixarntz]

@jjgrainger Opened this additional issue for the future, with ACs to review.

[eclarke1]

Would it be possible to please assign an estimate to this one @jjgrainger ?

[vishalkakadiya]

@felixarntz @joemcgill @jjgrainger I have raised PR for this task here. Thanks!

[felixarntz]

@vishalkakadiya @jjgrainger @eclarke1 Apologies for just spotting now that this is in milestone 1. I'm not sure that's a good idea because adding multisite support will entail more than this (e.g. making the AJAX requests correctly), and some of those other things will be more complicated. So if we only implement this issue, we would have a broken multisite support, which is probably worse than no multisite support at all.

I think we should focus on this only after we have a first working version and the repo is in the WordPress organization.

[eclarke1]

Thanks @felixarntz I have removed Milestone 1 and added Milestone 2, presumably this can sit in CR until such a time it's needed. Or do you think it may need additional work, and therefore should be moved back to AC?

[felixarntz]

@eclarke1 I think it can remain in CR, it's just that we will need to work on additional issues to get full multisite support, and those need to be explored and defined eventually. Maybe we can eventually work on it in a feature branch.

[vishalkakadiya]

I have updated the PR status from open to draft so we don't merge it accidentally. 🙂

[vishalkakadiya]

I'm assigning this to @jjgrainger, so he can continue on this once we unblock. Thanks!

[davidperezgar]

Hey, I've recored this issue to continue the development from last time.