Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect possible updater file inside vendor folder #651

Closed
wants to merge 3 commits into from
Closed

Detect possible updater file inside vendor folder #651

wants to merge 3 commits into from

Conversation

ernilambar
Copy link
Member

Fixes #640

@ernilambar ernilambar marked this pull request as ready for review September 20, 2024 07:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

mukeshpanchal27
mukeshpanchal27 requested changes Oct 7, 2024
View reviewed changes
includes/Checker/Checks/Plugin_Repo/Plugin_Updater_Check.php
Comment on lines +138 to +142
$updater_files = array(
'vendor/yahnis-elsts/plugin-update-checker/plugin-update-checker.php',
'vendor/plugin-update-checker/plugin-update-checker.php',
'vendor/kernl/kernl-update-checker/kernl-update-checker.php',
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we received any reports of similar issues?

In my opinion, we don't need to address plugin-specific issues at this time. Instead, I suggest we wait and see if more similar bugs are reported. If we observe a pattern, we can explore possible solutions then.

@ernilambar ernilambar closed this Oct 8, 2024
@ernilambar ernilambar deleted the 640-update-checker-inside-vendor-folder-not-detected branch October 20, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 requested changes

@davidperezgar davidperezgar davidperezgar approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update checker inside vendor folder is not detected
3 participants
@ernilambar @davidperezgar @mukeshpanchal27