Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors with severity less than a number as a warning #691

Open
davidperezgar opened this issue Oct 3, 2024 · 2 comments · May be fixed by #696
Open

Show errors with severity less than a number as a warning #691

davidperezgar opened this issue Oct 3, 2024 · 2 comments · May be fixed by #696
Assignees
Labels
[Team] Plugin Review Issues owned by Plugin Review Team

Comments

@davidperezgar
Copy link
Member

davidperezgar commented Oct 3, 2024

In WP-CLI, when we use severity, such as 7 for errors, we lose the results of those errors and they are not displayed. My proposal would be to show them as warnings, so the user can still address them since they are important, but they do not block the process.

The severity level 7 is used in the WordPress Plugin Submission, and it filters errors with a severity level lower than 7. That's correct, but we are losing other issues that, if the user received those results, they could work on them. However, it wouldn't block the submission. Therefore, we could display them as warnings.

@davidperezgar
Copy link
Member Author

What do you think @felixarntz, @swissspidy @ernilambar @barrykooij ?

@davidperezgar davidperezgar added the [Team] Plugin Review Issues owned by Plugin Review Team label Oct 14, 2024
@frantorres
Copy link
Contributor

It makes sense to display issues bellow the level of error as warnings (or "not blocking errors" to be more accurate and avoid confusion between what's an error and what's a warning).

I understand that this is related to the "filter" applied to the wp-cli command, so maybe will need a new parameter to say that we also want so see issues bellow 7 but not marked as an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team
Projects
None yet
4 participants