Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad filename issue #714

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fix bad filename issue #714

merged 2 commits into from
Oct 11, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Oct 11, 2024

Related #628

This removes the path before the plugin so that we dont worry about badly named folder issue out of plugin scope.

@ernilambar ernilambar marked this pull request as ready for review October 11, 2024 14:17
Copy link

github-actions bot commented Oct 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar
Copy link
Member

Should be launch a minor version for this?

@davidperezgar davidperezgar merged commit b5b33ec into trunk Oct 11, 2024
29 checks passed
@davidperezgar davidperezgar deleted the fix/bad-file-issue branch October 11, 2024 14:51
@davidperezgar
Copy link
Member

Thanks Nilambar

@swissspidy swissspidy added this to the 1.3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants