Restrict parse_str() without second argument

[ernilambar]

parse_str() without second argument is restricted.

Using this function without the result parameter is highly DISCOURAGED and DEPRECATED as of PHP 7.2. As of PHP 8.0.0, the result parameter is mandatory.

Developing sniff using AbstractFunctionParameterSniff would be most feasible route I believe.

[swissspidy]

The PHPCompatibility project has a dedicated PHPCompatibility.FunctionUse.OptionalToRequiredFunctionParameters sniff that catches exactly this.

No need to reinvent the wheel.

I would suggest addingPHPCompatibility as a whole to plugin-review.xml, as it helps plugins keep up to date with PHP compatibility

[ernilambar]

Do you mean adding PHPCompatibility.FunctionUse.OptionalToRequiredFunctionParameters or whole PHPCompatibility? I will discuss it in the team meeting accordingly.

Regarding parse_str() particularly, currently it is enforced in internal scanner for any PHP version. Would it be possible to customize OptionalToRequiredFunctionParametersSniff class?

[swissspidy]

I don‘t know, you will have to check