Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images in plugin used with img get marked as errors #757

Open
sc0ttkclark opened this issue Oct 28, 2024 · 0 comments
Open

Images in plugin used with img get marked as errors #757

sc0ttkclark opened this issue Oct 28, 2024 · 0 comments
Labels
[Team] Performance Issues owned by Performance Team

Comments

@sc0ttkclark
Copy link

Related to this sniff:

plugin-check/phpcs-sniffs/PluginCheck/Sniffs/CodeAnalysis/ImageFunctionsSniff.php

Line 62 in 02aeb3e

$this->phpcsFile->addError(

ERROR | PluginCheck.CodeAnalysis.ImageFunctions.NonEnqueuedImage | Images should be added using wp_get_attachment_image() or similar functions

The problem here is that plugins have their own <img src="<?php echo esc_url( $image_from_plugin) ); ?>" ... /> image tags output. These trigger the ERROR which seems like it should be a WARNING perhaps?
@ernilambar ernilambar added the [Team] Performance Issues owned by Performance Team label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Team] Performance Issues owned by Performance Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sc0ttkclark @ernilambar