Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The readme.txt file check is not specific enough #375

Open
carolinan opened this issue Jul 26, 2021 · 4 comments · May be fixed by #376
Open

The readme.txt file check is not specific enough #375

carolinan opened this issue Jul 26, 2021 · 4 comments · May be fixed by #376

Comments

@carolinan
Copy link
Collaborator

The readme.txt file check is intended to check if there is a readme.txt file that has information about the theme, but it will look for any readme.txt file.

If the themes readme.txt file is missing, but there is a third-party readme.txt file for a library inside a subfolder, the check passes.

Example theme:
https://themes.trac.wordpress.org/ticket/102187
The readme.txt file is inside https://themes.svn.wordpress.org/momentog/1.0/genericons/

@kafleg
Copy link
Member

kafleg commented Jul 27, 2021

We can check if the readme.txt file is in the theme root directory. And we can apply if the validator checks pass or not? https://wordpress.org/plugins/developers/readme-validator/

@kafleg
Copy link
Member

kafleg commented Jul 27, 2021

If there is a README.md file, it's not necessary to be readme.txt? This theme doesn't contain readme.txt, https://themes.svn.wordpress.org/games-online/1.1/

@carolinan
Copy link
Collaborator Author

It depends on what format is decided on once the readme is parsed in the theme directory.
https://meta.trac.wordpress.org/ticket/215#comment:41

@carolinan
Copy link
Collaborator Author

I saw that the plugin directory checks for both but uses readme.txt if that exists. So I think it should be the same for themes.

@carolinan carolinan linked a pull request Jul 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants