Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nav breadcrumbs to Events child theme #1014

Closed
iandunn opened this issue Aug 22, 2023 · 2 comments · Fixed by #1027
Closed

Add nav breadcrumbs to Events child theme #1014

iandunn opened this issue Aug 22, 2023 · 2 comments · Fixed by #1027
Assignees
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Aug 22, 2023

The Events site uses the global header/footer, but doesn't have a link in either of them. If someone is on one of the landing pages (see #1007), then won't have any link to go to the events.wordpress.org homepage, only w.org. That may confuse visitors.

We could add a nav breadcrumb like the News theme has on pages like https://wordpress.org/news/2023/08/lionel/

@ryelle
Copy link
Contributor

ryelle commented Aug 22, 2023

There's a local navigation block in wporg-mu-pluigns, which handles the breadcrumbs in the About & Download subpages, that could be used here? Here's an example of how it's used on download.

Screen Shot 2023-08-22 at 15 54 22

Also see WordPress/wporg-mu-plugins#465, it's still evolving but if you use the block hopefully it should inherit those improvements 🙂

@iandunn
Copy link
Member Author

iandunn commented Aug 22, 2023

That looks perfect, thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants