Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordCamp Participation Notifier should run when an eligible CPT is published #809

Open
CdrMarks opened this issue Dec 21, 2022 · 3 comments · May be fixed by #964
Open

WordCamp Participation Notifier should run when an eligible CPT is published #809

CdrMarks opened this issue Dec 21, 2022 · 3 comments · May be fixed by #964
Assignees
@timiwahalahti
Labels
[Component] Participation Notifier [Priority] High [Type] Bug [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase

Comments

@CdrMarks
Copy link
Collaborator

Describe the bug

WordPress.org usernames added to a draft Organizer/Speaker CPT and then published later does not cause the relevant activity to show on the user's profile activity log.

To reproduce

Steps to reproduce the behavior:

  1. Create a new Organizer/Speaker CPT
  2. Add a WordPress.org username
  3. Save as Draft
  4. Publish

Expected behavior

The relevant activity shows on the user's profile activity log.

WordCamp

All
Reported by @vertizio on behalf of WordCamp Europe 2023
https://wordpress.slack.com/archives/C08M59V3P/p1671612328793169
@timiwahalahti timiwahalahti added [Type] Bug [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase [Priority] 1 labels Dec 21, 2022
@timiwahalahti
Copy link
Collaborator

Instead of solely relying to update_post_meta add_post_meta and delete_post_meta actions in wordcamp-participation-notifier plugin, we probably should create publish_{post_type} actions to send the badge/activity and from meta hooks use only delete_post_meta.

@iandunn
Copy link
Member

iandunn commented Dec 22, 2022

That's a good idea 👍🏻

@timiwahalahti
Copy link
Collaborator

Since the receiving part of the notifications is closed source, is there a way to test this if I'd do a PR?

@timiwahalahti timiwahalahti self-assigned this Jul 19, 2023
@timiwahalahti timiwahalahti linked a pull request Jul 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timiwahalahti timiwahalahti

Labels
[Component] Participation Notifier [Priority] High [Type] Bug [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase
Projects
Community Events Active Tasks
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run WordCamp Participation Notifier when post is published timiwahalahti/wordcamp.org
4 participants
@timiwahalahti @iandunn @CdrMarks @renintw