Show days deleted posts will be left for in trash. #6932
Closed
+79,229
−60,312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jorbin602fd350-edb4-49c9-b593-d223f7449a82. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Debarghya-Banerjee
suggested changes
Jul 10, 2024
|
Thanks @Debarghya-Banerjee , the suggested changes has been committed. |
git-svn-id: https://develop.svn.wordpress.org/trunk@59237 602fd350-edb4-49c9-b593-d223f7449a82
Bootstrap block bindings sources earlier in the process through an inline script to ensure they are available when developers want to extend them in the client. Following the same pattern other APIs like registering block types are doing. Props santosguillamot, cbravobernal, gziolo. Fixes WordPress#6225. git-svn-id: https://develop.svn.wordpress.org/trunk@59238 602fd350-edb4-49c9-b593-d223f7449a82
There is a bug where the attributes panel is not shown in custom post types. This is caused because each post type can define a capability_type, which by default is post, so the logic to map the capabilities wasn't correct and it was returning false. Props santosguillamot, cbravobernal. Fixes #62226. git-svn-id: https://develop.svn.wordpress.org/trunk@59239 602fd350-edb4-49c9-b593-d223f7449a82
…ig-sample.php`. This replaces the DB abbreviation for consistency, and aims to make the sentence a bit more clear. Follow-up to [59044]. See #34189. git-svn-id: https://develop.svn.wordpress.org/trunk@59240 602fd350-edb4-49c9-b593-d223f7449a82
Prevent possible PHP warnings caused by malformed enclosure meta data. This change ensures the enclosure meta data has at least three lines of text before generating the tag in `rss_enclosure()`. Props arypneta, johnjamesjacoby, nihar007, rahmohn, rghedin, zahardoc. Fixes #58798. git-svn-id: https://develop.svn.wordpress.org/trunk@59241 602fd350-edb4-49c9-b593-d223f7449a82
Relocate the defintion of `absint()` to `load.php` to allow it to be available to `get_current_blog_id()` and `get_current_network_id()`. These functions may be called by caching drop-ins, prior to the loading of `functions.php`. Props flixos90, geekofshire, johnjamesjacoby, sergeybiryukov, wonderboymusic. Fixes #40682. git-svn-id: https://develop.svn.wordpress.org/trunk@59242 602fd350-edb4-49c9-b593-d223f7449a82
…g conventions. Includes: * Moving `@covers` tags to the class-level DocBlock, since this is the only function tested in the class. * Adjusting the assertion messages for clarity, as `rss_enclosure()` does not return anything directly. * Using a static closure for improved performance. Follow-up to [59241]. See #61530. git-svn-id: https://develop.svn.wordpress.org/trunk@59243 602fd350-edb4-49c9-b593-d223f7449a82
Load block patterns for bundled themes on the `init` hook to avoid triggering notices caused by loading the translations too early. The change is applied to Twenty Ten, Twenty Twelve, Twenty Thirteen, Twenty Fourteen, Twenty Fifteen, Twenty Sixteen and Twenty Twenty. Props domainsupport, swissspidy. Fixes #62237. See #44937. git-svn-id: https://develop.svn.wordpress.org/trunk@59244 602fd350-edb4-49c9-b593-d223f7449a82
Possesive "it's" should be "its." Follow-up to [59076]. Props jonsurrell. Fixes #62036. git-svn-id: https://develop.svn.wordpress.org/trunk@59245 602fd350-edb4-49c9-b593-d223f7449a82
This is a maintenance release with minor bug fixes. References: * [https://github.com/PHPMailer/PHPMailer/releases/tag/v6.9.2 PHPMailer 6.9.2 release notes] * [PHPMailer/PHPMailer@v6.9.1...v6.9.2 Full list of changes in PHPMailer 6.9.2] Follow-up to [50628], [50799], [51169], [51634], [51635], [52252], [52749], [52811], [53500], [53535], [53917], [54427], [54937], [55557], [56484], [57137]. Props ayeshrajans. Fixes #62206. git-svn-id: https://develop.svn.wordpress.org/trunk@59246 602fd350-edb4-49c9-b593-d223f7449a82
Fix an issue where Imagick did not properly set image quality for AVIF images. Adds a call to `setCompressionQuality` where we currently call `setImageCompressionQuality` Props: jamesosborne, adamsilverstein, mukeshpanchal27. Fixes: #61614. git-svn-id: https://develop.svn.wordpress.org/trunk@59247 602fd350-edb4-49c9-b593-d223f7449a82
Form tag closers have complicated conditions. There was a bug where the HTML Processor would not stop correctly on a FORM tag closer token. This changeset ensures that that token is reachable. Developed in WordPress#7582 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [58779]. Props jonsurrell. Fixes #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@59248 602fd350-edb4-49c9-b593-d223f7449a82
… file. This switches from using the `test`/`cp` commands when copying the `.env.example` file to using `node:fs`. `test` and `cp` are not available on Windows machines. This also adds the `.env` file to the `svn:ignore` list to prevent it from being committed accidentally. Follow up to [59038]. Props afercia, Clorith, poena. Fixes #52668. git-svn-id: https://develop.svn.wordpress.org/trunk@59249 602fd350-edb4-49c9-b593-d223f7449a82
…when length differs There was an edge case detected for updating the text placed without the wrapping HTML tag with `set_modifiable_text`. Props gziolo, jonsurrell. Fixes #62241. git-svn-id: https://develop.svn.wordpress.org/trunk@59250 602fd350-edb4-49c9-b593-d223f7449a82
This adds a `phpunit-test-goups` input to the reusable PHPUnit test workflow for added flexibility. When passed, only the specified test groups are run. Props jrf. See #52668. git-svn-id: https://develop.svn.wordpress.org/trunk@59251 602fd350-edb4-49c9-b593-d223f7449a82
Some GitHub Action workflows use the `paths` filter to limit when workflows run for pull requests. This helps avoid running workflows unnecessarily when the pull request does not change any relevant code. Currently, a few of these workflows are configured to run when any `.yml` file in the `.github/workflows/` directory is changed. This updates those workflows to target more specific workflow files for more efficient running. See #61564. git-svn-id: https://develop.svn.wordpress.org/trunk@59252 602fd350-edb4-49c9-b593-d223f7449a82
This improves the logic in `WP_Theme_JSON::compute_style_properties` to address a number of performance issues. Props spacedmonkey. Fixes #59595. git-svn-id: https://develop.svn.wordpress.org/trunk@59253 602fd350-edb4-49c9-b593-d223f7449a82
[59252] made the path filtering a bit too broad for the Test Old Branches workflow. Though `v3` of the reusable PHPUnit workflow is used by some older branches, this version is updated much more frequently because it’s the latest version. To limit the number of times this workflow runs, old branches should only be tested when old versions of the workflow are updated. Follow up to [59252]. See #61564. git-svn-id: https://develop.svn.wordpress.org/trunk@59254 602fd350-edb4-49c9-b593-d223f7449a82
… the receiving site. This aims to avoid a subsequent fatal error from `mb_convert_encoding()` when an invalid charset is specified. Follow-up to [1734], [2563], [12032]. Props dd32, jrf, oglekler, rajinsharwar. Fixes #60261. git-svn-id: https://develop.svn.wordpress.org/trunk@59255 602fd350-edb4-49c9-b593-d223f7449a82
This caches the generated CSS from block nodes in merged Theme JSON data to avoid repeated costly operations required to compute style properties for blocks. The generated CSS is saved to a transient that expires every hour. This is a follow-up that reimplements [58334], which was previously reverted in [58710]. Props thekt12, spacedmonkey, pereirinha, mukesh27, isabel_brison, oandregal, andrewserong, ramonjd, joemcgill, costdev, aaronrobertshaw, peterwilsoncc. Fixes #61679. See #59595. git-svn-id: https://develop.svn.wordpress.org/trunk@59256 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a fatal error in `array_keys()` (PHP 8.0+) as `$wp_filesystem->dirlist()` will return `false` when the source directory doesn't exist or becomes unreadable for some reason. Props: verygoode, lifelightweb, da5f656f, costdev, afragen, azaozz Fixes #61114 git-svn-id: https://develop.svn.wordpress.org/trunk@59257 602fd350-edb4-49c9-b593-d223f7449a82
Includes adjusting the method DocBlock per the documentation standards. Follow-up to [56448]. See #61608. git-svn-id: https://develop.svn.wordpress.org/trunk@59258 602fd350-edb4-49c9-b593-d223f7449a82
…le_element()`. `wp_print_font_faces()` prints an HTML tag that can be used more than once, so the document could end up having multiple tags with the same `id` attribute. The `id` global attribute defines an identifier (ID) which must be unique in the whole document. Reference: [https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id MDN Web Docs: id]. Follow-up to [56500]. Props mmaattiiaass, peterwilsoncc. Fixes #62246. git-svn-id: https://develop.svn.wordpress.org/trunk@59259 602fd350-edb4-49c9-b593-d223f7449a82
Loads the font family files from style variations defined within a theme for user in the site and post editors. This is to ensure the fonts are shown while editing without the need for a reload after switching styles. Props ironprogrammer, mmaattiiaass. Fixes #62231. git-svn-id: https://develop.svn.wordpress.org/trunk@59260 602fd350-edb4-49c9-b593-d223f7449a82
The DocBlock of `WP_Term_Query::__construct` mentions the count argument, however, this argument is not supported in `WP_Term_Query::get_terms()`. Props sergeybiryukov, swissspidy, snehapatil02, tyrannous. Fixes #61094. git-svn-id: https://develop.svn.wordpress.org/trunk@59261 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [59532]. See #60638. git-svn-id: https://develop.svn.wordpress.org/trunk@59533 602fd350-edb4-49c9-b593-d223f7449a82
None of the steps in any of the workflows use svn, so this debugging step is unnecessary, and svn has been removed in the ubuntu-24.04 runner which will be rolling out to GitHub Actions imminently. See #62221 git-svn-id: https://develop.svn.wordpress.org/trunk@59534 602fd350-edb4-49c9-b593-d223f7449a82
In 6.7, [58775] changed the way `react` and `react-dom` are bundled in Core. This commit resulted in some changes to the built files that are distributed in WordPress even though the actual version of the libraries remained the same. The result can be a blank white screen when trying to edit a post when those two script files are heavily cached. This adds `-umd` to the end of the version number to properly purge caches until the next update to these libraries occurs. Props levskipg, get_dave, smerriman, jdnd, juanwp22, seanlanglands, robertstaddon. Fixes 62422. git-svn-id: https://develop.svn.wordpress.org/trunk@59536 602fd350-edb4-49c9-b593-d223f7449a82
Replaces the `-umd` appendage for the `react` and `react-dom` script versions with `.1`. This it to prevent issues with third party code expecting the version number in the form `/^[\d\.]+$/`. Updates the version to tests in `Tests_Dependencies_Scripts::test_vendor_script_versions_registered_manually` to include the modified version used for cache busting. Follow up to [59536], [58775]. Props azaozz, desrosj, peterwilsoncc. Fixes #62422. git-svn-id: https://develop.svn.wordpress.org/trunk@59540 602fd350-edb4-49c9-b593-d223f7449a82
…()`. The Credits API has been updated to return SHA-256 email hashes. Follow-up to [59532], [meta14307]. Props haozi. Fixes #62706, #60638. git-svn-id: https://develop.svn.wordpress.org/trunk@59541 602fd350-edb4-49c9-b593-d223f7449a82
…cBlock. Follow-up to [38715], [52226]. Props kkmuffme, mukesh27. Fixes #62714. git-svn-id: https://develop.svn.wordpress.org/trunk@59542 602fd350-edb4-49c9-b593-d223f7449a82
Apply Block Hooks to synced patterns (i.e. `core/block` instances). Props bernhard-reiter, gziolo. Fixes #62704. git-svn-id: https://develop.svn.wordpress.org/trunk@59543 602fd350-edb4-49c9-b593-d223f7449a82
…upport. Ignore the `format` parameter introduced in WordPress 6.7 for post types that do not support post formats. This protects against a fatal error being thrown in later version of PHP or a warning in earlier versions of PHP. Follow up to r59115. Props dd32, sergeybiryukov, yogeshbhutkar. Fixes #62646. See #62014. git-svn-id: https://develop.svn.wordpress.org/trunk@59544 602fd350-edb4-49c9-b593-d223f7449a82
Introduces translatable strings for additional [https://make.wordpress.org/core/handbook/about/release-cycle/wordpress-release-team-and-focus-leads/ release squad titles]. This is to allow improved acknowledgement of an individual's role in a release squad by enabling the use of these roles in the credits API going forward. Props audrasjb, desrosj, jorbin, timse201, yogeshbhutkar. Fixes #62386. git-svn-id: https://develop.svn.wordpress.org/trunk@59545 602fd350-edb4-49c9-b593-d223f7449a82
…l functions. Follow-up to [12320], [12351], [20646], [32618], [34167], [34373], [37915]. Props apermo, jasonsa19. Fixes #62720. git-svn-id: https://develop.svn.wordpress.org/trunk@59548 602fd350-edb4-49c9-b593-d223f7449a82
Props shailu25. Fixes #62730. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59549 602fd350-edb4-49c9-b593-d223f7449a82
This changeset fixes an issue in the Media Library where icons or thumbnails of uploaded files were stuck to the border of their container after file upload. Follow-up to [58279]. Props sukhendu2002, im3dabasia1, sainathpoojary, joedolson. Fixes #62573. See #60141. git-svn-id: https://develop.svn.wordpress.org/trunk@59550 602fd350-edb4-49c9-b593-d223f7449a82
…ncy. This changeset addresses adjusts margins around the login form for visual consistency. The margin above and below the form is now consistently set to 24px, and the margin below the logo has also been adjusted to 24px. Follow-up to [26072]. Props deeppatel8950, audrasjb, priyank9033, viralsampat, vijaysinh9094, sabernhardt, . Fixes #61667. git-svn-id: https://develop.svn.wordpress.org/trunk@59551 602fd350-edb4-49c9-b593-d223f7449a82
…slation tools. Follow-up to [59545]. See #62386. git-svn-id: https://develop.svn.wordpress.org/trunk@59552 602fd350-edb4-49c9-b593-d223f7449a82
…mobile. This changeset fixes an issue where the theme browser created unwanted horizontal scrolling on some mobile devices. The issue occured when viewing theme details on mobile. Follow-up to [26142]. Props wildworks, abcd95, sainathpoojary, dhruvang21, sabernhardt. Fixes #62411. git-svn-id: https://develop.svn.wordpress.org/trunk@59553 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adds a `noun` or `verb` context to the various occurrences of "upload" in the admin, to make it easier for translators to differenciate these strings depending on the context. Props timse201, wpgerd. Fixes #62732. git-svn-id: https://develop.svn.wordpress.org/trunk@59554 602fd350-edb4-49c9-b593-d223f7449a82
In [59224], customizer accordion item HTML structure was changed to include a `button` element as the interactive control. However, some themes inject custom markup for panel headings. Fix `controls.js` to handle both the new markup and the old markup, which is relatively common in themes. Props paullb, desrosj, sabernhardt, joedolson, jorbin. Fixes #62494. git-svn-id: https://develop.svn.wordpress.org/trunk@59555 602fd350-edb4-49c9-b593-d223f7449a82
…ion()`. Follow-up to [549], [1985], [2464], [2556], [2558], [34799], [40667]. Props deepakrohilla, narenin. See #62316. git-svn-id: https://develop.svn.wordpress.org/trunk@59556 602fd350-edb4-49c9-b593-d223f7449a82
…()`. Follow-up to [14298], [19852]. Props debarghyabanerjee. See #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59557 602fd350-edb4-49c9-b593-d223f7449a82
…hp`. Follow-up to [58703]. Props mukesh27. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59558 602fd350-edb4-49c9-b593-d223f7449a82
Add the ID `wp-skip-link` to the block theme generated skip link, so that block themes have a standardized target at the top of the `body` element. Props philliproth, audrasjb, debarghyabanerjee, sabernhardt, joedolson, apermo. Fixes #62311. git-svn-id: https://develop.svn.wordpress.org/trunk@59559 602fd350-edb4-49c9-b593-d223f7449a82
…tion()`. Follow-up to [https://mu.trac.wordpress.org/changeset/1970 mu:1970]. Props debarghyabanerjee. See #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59560 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [https://mu.trac.wordpress.org/changeset/543 mu:543]. Props debarghyabanerjee, aristath, poena, afercia, SergeyBiryukov. See #62279, #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59561 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [https://mu.trac.wordpress.org/changeset/804 mu:804], [https://mu.trac.wordpress.org/changeset/1918 mu:1918]. Props debarghyabanerjee, aristath, poena, afercia, SergeyBiryukov. See #62279, #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59562 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [https://mu.trac.wordpress.org/changeset/1640 mu:1640]. Props debarghyabanerjee, aristath, poena, afercia, SergeyBiryukov. See #62279, #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59563 602fd350-edb4-49c9-b593-d223f7449a82
|
Closing this PR as lot of files were outdated on my branch, so I merged trunk with it to update them and it messed up the PR with lot of commits 🤦♂️ |
|
@Debarghya-Banerjee please follow this fresh PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/61511
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.