Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sticky local nav and breadcrumbs after global header update #298

Closed
ryelle opened this issue Oct 4, 2023 · 1 comment · Fixed by #334
Closed

Fix sticky local nav and breadcrumbs after global header update #298

ryelle opened this issue Oct 4, 2023 · 1 comment · Fixed by #334
Assignees
Labels
Milestone

Comments

@ryelle
Copy link
Contributor

ryelle commented Oct 4, 2023

When WordPress/wporg-mu-plugins#466 merges, it will unstick the global header and only stick the local nav (and breadcrumbs). This will affect the way the local navigation bar stickiness works on the Developers site, because it uses the is-sticky helper class. Instead, it can now use "position":{"type":"sticky"} to use the gutenberg sticky behavior.

Screen Shot 2023-10-04 at 16 06 31

See WordPress/wporg-documentation-2022#71 for a similar fix on documentation.

@adamwoodnz adamwoodnz modified the milestones: Iteration 1, MVP Nov 2, 2023
@adamwoodnz adamwoodnz self-assigned this Nov 5, 2023
@adamwoodnz adamwoodnz reopened this Nov 9, 2023
@adamwoodnz
Copy link
Contributor

Closed by #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants