Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks landing page: Better labels for links #311

Closed
alexstine opened this issue Aug 11, 2023 · 6 comments
Closed

Blocks landing page: Better labels for links #311

alexstine opened this issue Aug 11, 2023 · 6 comments
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Content Bugs or issues related to the page content

Comments

@alexstine
Copy link

alexstine commented Aug 11, 2023

From: #245

Most of the links on the page have great context but there are some that could use some improvement.

  1. Link: Try it live
    Suggestion: Try Gutenberg live
    Reasoning: Try what live?
  2. Link: View documentation
    Suggestion: Create a Block
    Reasoning: This link goes to the Create a Block Tutorial, not generic docs.
  3. Please eliminate the "↗︎" icons on the links under the "Only the beginning" heading 2. You never know what screen readers will do when they come in contact with arrows. In all fairness, up arrows really don't make much sense here.

Page: https://wordpress.org/blocks/

@ryelle ryelle added Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Content Bugs or issues related to the page content labels Aug 12, 2023
@joedolson
Copy link

The problem isn't that the arrow character is present, but that it needs to be hidden from screen readers. Decorative images (which includes font icons, svg, and any character used for graphical rather than lexical purposes) should always be wrapped in containers with aria-hidden. What screen readers will do when they encounter non-text characters can be very unpredictable.

@ryelle ryelle moved this to 📋 To do in WordPress.org Aug 14, 2023
@ryelle
Copy link
Contributor

ryelle commented Aug 14, 2023

cc @annezazu for the link label suggestions ^

The list of links with arrows is a common visual design pattern, it's used on the homepage too. We can programmatically wrap them in aria-hidden. I can't think of a case where they're used in a non-decorative capacity (and it sounds like they shouldn't be, anyway).

@annezazu
Copy link

Thank you for this feedback! I've included it in the next iteration tracking issue. Here's what I'm going with:

Link: Try it live
Suggestion: Try Gutenberg live
Reasoning: Try what live?

Going with "Try blocks live" since it's more about blocks rather than Gutenberg.

Link: View documentation
Suggestion: Create a Block
Reasoning: This link goes to the Create a Block Tutorial, not generic docs.

Updated to "Create a block". I don't love that we say create twice but we can always iterate again.

Please eliminate the "↗︎" icons on the links under the "Only the beginning" heading 2. You never know what screen readers will do when they come in contact with arrows. In all fairness, up arrows really don't make much sense here.

I've noted this as a task for Kelly to follow up on.

@alexstine
Copy link
Author

Looks good. 👍 Thanks.

@ryelle
Copy link
Contributor

ryelle commented Aug 16, 2023

Please eliminate the "↗︎" icons on the links under the "Only the beginning" heading 2.

I've just deployed some code to automatically wrap those arrows in aria-hidden. With that, I think everything here has been addressed.

@ryelle ryelle closed this as completed Aug 16, 2023
@alexstine
Copy link
Author

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Content Bugs or issues related to the page content
Projects
Archived in project
Development

No branches or pull requests

4 participants