Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate sticky headers obscured #124

Closed
iandunn opened this issue Jan 25, 2022 · 6 comments
Closed

Translate sticky headers obscured #124

iandunn opened this issue Jan 25, 2022 · 6 comments
Assignees
Labels
[Type] Bug Something isn't working
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Jan 25, 2022

@zackkrida in #38 (comment):

When viewing a list of translation strings like https://translate.wordpress.org/projects/wp/dev/dsb/default/?page=4, each translation has its own sticky header and menu:

CleanShot 2022-01-24 at 18 43 58@2x

These can be obscured by the sticky header, which is particularly frustrating on short (namely small laptop and ultrabook) displays:

before
CleanShot 2022-01-24 at 18 49 17@2x

after
CleanShot 2022-01-24 at 18 49 01@2x

@iandunn iandunn added the [Type] Bug Something isn't working label Jan 25, 2022
@iandunn iandunn added this to the News launch milestone Jan 25, 2022
@ocean90
Copy link
Member

ocean90 commented Jan 25, 2022

This was already fixed in https://meta.trac.wordpress.org/changeset/11469 I think.

@iandunn
Copy link
Member Author

iandunn commented Jan 25, 2022

Is that working for you? It wasn't in my testing.

@ocean90
Copy link
Member

ocean90 commented Jan 25, 2022

Odd, seems like it's only working when logged-in for me.

@iandunn
Copy link
Member Author

iandunn commented Jan 25, 2022

Huh, it doesn't seem to work in either state for me 🤷🏻

@dd32
Copy link
Member

dd32 commented Jan 31, 2022

https://meta.trac.wordpress.org/changeset/11469 did indeed fix it, but it was then broken by https://meta.trac.wordpress.org/changeset/11470.

@iandunn
Copy link
Member Author

iandunn commented Jan 31, 2022

Ah, that makes sense now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants