Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localise the header/footer text on sites that switch locale #133

Closed
dd32 opened this issue Feb 1, 2022 · 1 comment
Closed

Localise the header/footer text on sites that switch locale #133

dd32 opened this issue Feb 1, 2022 · 1 comment
Assignees
@dd32
Labels
[Type] Bug Something isn't working
Milestone
News: Post-launch...

Comments

@dd32
Copy link
Member

dd32 commented Feb 1, 2022

#46 localised the header/footer, but displays them in English on sites that switch the locale, such as https://learn.wordpress.org/?locale=es_ES

This is likely as the wporg textdomain isn't being loaded, isn't being loaded early enough, or the locale switcher is kicking in too late.
Displaying the Header/Footer in English, but the content in another language is somewhat unexpected, especially when we've marked the strings as translatable.

While the menu's probably won't match that on a rosetta subdomain (ie. es.wordpress.org as with the above example) right now, it'll be closer. #125 might make them closer too.
@dd32 dd32 added this to the News: Post-launch iteration 2 milestone Feb 1, 2022
@iandunn iandunn added the [Type] Bug Something isn't working label Feb 11, 2022
@dd32 dd32 self-assigned this Mar 4, 2022
bazza pushed a commit to WordPress/wordpress.org that referenced this issue Mar 4, 2022
@dd32
Locale Switcher: use a newer Hook to override the locale earlier, and…
606041c 
… hook immediately, as some plugins use translation functions upon inclusion.

Handbooks: Don't call translation functions upon plugin inclusion, causing translations to load before plugins are loaded.

See WordPress/wporg-mu-plugins#133


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@11640 74240141-8908-4e6f-9713-ba540dce6ec7
@dd32
Copy link
Member Author

dd32 commented Mar 4, 2022

Fixed through WordPress/wordpress.org@606041c

The wporg text-domain was being loaded before the locale switcher was setting the locale.

This was made slightly worse by the locale switching plugin delaying loading it's hooks, and also not forcibly switching the locale (which it still doesn't).

@dd32 dd32 closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dd32 dd32

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
News: Post-launch iteration 1
Development

No branches or pull requests
2 participants
@iandunn @dd32