Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rosetta sites in header #17

Closed
iandunn opened this issue Oct 22, 2021 · 1 comment
Closed

Support rosetta sites in header #17

iandunn opened this issue Oct 22, 2021 · 1 comment
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Oct 22, 2021

Has Rosetta been taken into account with the header design too? ie. The need for different header texts, custom menu items, etc.
Doesn’t look like the design has any textual header locations, so any “localisation” headers (ie. WordPress.org Deutsch ) would probably be outside of the header and in the body.
This may be a sticking point for rolling it out to older themes, as they rely upon the global header for some kind of WordPress.org header/branding of the page.
Looks like nav menus would be possible to include, but it is not designed for it as all links are hard-coded.

@beahfialho, how do you see Rosetta sites like https://es.wordpress.org/ working w/ the new header?

Maybe everything is the same, except that the menu/search are for the current site only, rather than the entire network?

might want to get feedback from the polyglots team too. cc @ocean90 (for context, see https://make.wordpress.org/design/2021/06/03/redesign-of-wordpress-org-news/ and https://www.figma.com/file/O9I8Jl7kaUMTX39LlRGbGO/News-Page?node-id=4659%3A8203)

cc @dd32

@iandunn
Copy link
Member Author

iandunn commented Jan 5, 2022

I think this has been done, or will be done, in other issues:

different header texts

#50

custom menu items

#49
#46
#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant