Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Active states isn’t consistent #358

Closed
jasmussen opened this issue Mar 28, 2023 · 3 comments
Closed

Navigation: Active states isn’t consistent #358

jasmussen opened this issue Mar 28, 2023 · 3 comments

Comments

@jasmussen
Copy link
Collaborator

jasmussen commented Mar 28, 2023

From #221:

(Mobile) The behavior of active instances isn’t consistent (ie: Get WP vs Learn WP).

This also affects desktop. Here's Learn, with both the Learn menu item, and the ancestor item active:

Screenshot 2023-03-28 at 09 57 32

Here's Download, with no items active, even if conceptually it should be "Get WordPress" that's active:

Screenshot 2023-03-28 at 09 57 43

Consider also #229 as far as highlighting the ancestor.

@jasmussen
Copy link
Collaborator Author

My apologies, I created this issue in the wrong repository. @StevenDufresne or @ryelle are you able to move this to wporg-main-2022?

@ryelle
Copy link
Contributor

ryelle commented Mar 28, 2023

This is the correct place for these global header issues.

The outcome you want is for "Get WordPress"/Download to be highlighted, mirroring the behavior of Learn, is that right?

@ryelle ryelle moved this to 📋 To do in WordPress.org Mar 28, 2023
@ryelle ryelle self-assigned this Mar 28, 2023
@ryelle ryelle closed this as completed in 2f0d5cd Mar 28, 2023
@ryelle ryelle moved this from 📋 To do to ✅ Done in WordPress.org Mar 28, 2023
@jasmussen
Copy link
Collaborator Author

The outcome you want is for "Get WordPress"/Download to be highlighted, mirroring the behavior of Learn, is that right?

If we keep the dropdown called "Download & Extend" with a download link inside, then yes. But just for awareness, the ancestor might need consideration per #370, and there's #360 for download. Separate conversations. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants